ci: set correct base branch label #32325

DamianGlowala · 2025-06-06T17:15:09Z

📚 Description

Corrects PR labelling by differentiating between 3.x and 4.x.

bolt-new-by-stackblitz · 2025-06-06T17:15:12Z

Run & review this pull request in StackBlitz Codeflow.

Copilot

Pull Request Overview

This PR enhances the workflow’s PR labelling by detecting whether the base branch is 3.x or 4.x and applying the corresponding label.

Extract baseLabel from the pull request’s base branch
Update baseBranchLabelName to select between 3.x and 4.x based on the base branch
Retain only the necessary label addition logic

Copilot · 2025-06-06T17:16:13Z

.github/workflows/label-pr.yml

@@ -26,13 +26,17 @@ jobs:
            const labelsToAdd = []

            const pullRequest = {
+              baseLabel: '${{ github.event.pull_request.base.label }}',


The GitHub Actions context property for the base branch name is github.event.pull_request.base.ref, not .base.label. Using the wrong key will make baseLabel undefined.

Suggested change

baseLabel: '${{ github.event.pull_request.base.label }}',

baseLabel: '${{ github.event.pull_request.base.ref }}',

Copilot · 2025-06-06T17:16:14Z

.github/workflows/label-pr.yml

+            }[pullRequest.baseLabel]

            if (!pullRequest.labelsNames.includes(baseBranchLabelName)) {


If pullRequest.baseLabel doesn’t match any key, baseBranchLabelName becomes undefined. Add a default case or validate before pushing the label.

Suggested change

}[pullRequest.baseLabel]

if (!pullRequest.labelsNames.includes(baseBranchLabelName)) {

}[pullRequest.baseLabel] || 'unknown'

if (baseBranchLabelName !== 'unknown' && !pullRequest.labelsNames.includes(baseBranchLabelName)) {

pkg-pr-new · 2025-06-06T17:19:02Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@32325

nuxt

npm i https://pkg.pr.new/nuxt@32325

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@32325

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@32325

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@32325

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@32325

commit: c0ce6af

coderabbitai · 2025-06-06T17:20:48Z

Walkthrough

The GitHub Actions workflow for labelling pull requests was updated to replace a hardcoded base branch label with a dynamic mapping system. The script now determines the appropriate label to apply by referencing a mapping object keyed by the pull request’s base branch label, such as 'nuxt:main' or 'nuxt:3.x'. A new property, baseLabel, is introduced to capture the base branch label from the GitHub event, and this value is used to select the correct label from the mapping. No other logic or exported entities were changed.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (3)

.github/workflows/label-pr.yml (3)
28-33: Validate and clarify baseLabel extraction
The new baseLabel field uses ${{ github.event.pull_request.base.label }} to derive the owner:branch string (e.g. nuxt:main). Confirm this resolves to exactly the expected format in all cases and consider renaming to baseBranchLabel for clarity.

36-39: Handle unmapped base branch labels gracefully
The lookup { 'nuxt:main': '4.x', 'nuxt:3.x': '3.x' }[pullRequest.baseLabel] will yield undefined for any unexpected baseLabel. Introduce a default mapping or throw a clear error when baseBranchLabelName is falsy to avoid accidental undefined labels.

41-43: Guard against adding undefined labels
Currently, labelsToAdd.push(baseBranchLabelName) runs even if baseBranchLabelName is undefined, resulting in an invalid label. Add a truthy check before pushing:
-if (!pullRequest.labelsNames.includes(baseBranchLabelName)) {
-  labelsToAdd.push(baseBranchLabelName)
-}
+if (baseBranchLabelName && !pullRequest.labelsNames.includes(baseBranchLabelName)) {
+  labelsToAdd.push(baseBranchLabelName)
+}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 156a80b and c0ce6af.

📒 Files selected for processing (1)

.github/workflows/label-pr.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: build
GitHub Check: code

codspeed-hq · 2025-06-06T17:29:21Z

CodSpeed Performance Report

Merging #32325 will not alter performance

_{Comparing ci/label-pr-workflow (c0ce6af) with main (156a80b)}

Summary

✅ 10 untouched benchmarks

ci: set correct base branch label

c0ce6af

Copilot AI review requested due to automatic review settings June 6, 2025 17:15

DamianGlowala requested a review from danielroe as a code owner June 6, 2025 17:15

github-actions bot added 3.x chore labels Jun 6, 2025

Copilot AI reviewed Jun 6, 2025

View reviewed changes

coderabbitai bot reviewed Jun 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ci: set correct base branch label #32325

ci: set correct base branch label #32325

Uh oh!

DamianGlowala commented Jun 6, 2025

Uh oh!

bolt-new-by-stackblitz bot commented Jun 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jun 6, 2025

Uh oh!

Copilot AI Jun 6, 2025

Uh oh!

pkg-pr-new bot commented Jun 6, 2025

Uh oh!

coderabbitai bot commented Jun 6, 2025

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

codspeed-hq bot commented Jun 6, 2025

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

	baseLabel: '${{ github.event.pull_request.base.label }}',
	baseLabel: '${{ github.event.pull_request.base.ref }}',

		}[pullRequest.baseLabel]

		if (!pullRequest.labelsNames.includes(baseBranchLabelName)) {

Uh oh!

ci: set correct base branch label #32325

Are you sure you want to change the base?

ci: set correct base branch label #32325

Uh oh!

Conversation

DamianGlowala commented Jun 6, 2025

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented Jun 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Jun 6, 2025

Uh oh!

coderabbitai bot commented Jun 6, 2025

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed-hq bot commented Jun 6, 2025

CodSpeed Performance Report

Merging #32325 will not alter performance

Summary

Uh oh!

Uh oh!

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

CodeRabbit Configuration File (`.coderabbit.yaml`)