[CTL] Add CTL by handle #1073
Merged
[CTL] Add CTL by handle #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18c4254 to
83b32fb
Compare
lplewa
requested changes
Feb 4, 2025
There was a problem hiding this comment.
I whould also love to see "umf.pool.byhandle" in this PR. It should not be a huge extra work (this is literaly copy paste of umf.provider.byhandle", so extra work is a one extra entry in a pool and test). This would give use completed feature set"byhandle" as PR title says.
include/umf/base.h
Outdated
| @@ -48,6 +48,16 @@ typedef enum umf_result_t { | |||
| UMF_RESULT_ERROR_UNKNOWN = 0x7ffffffe ///< Unknown or internal error | |||
| } umf_result_t; | |||
|
|
|||
| /// @brief Type for determine the type of the CTL query | |||
| enum ctl_query_type { | |||
There was a problem hiding this comment.
- Typedef
- Please use umf_prefix
src/ctl/ctl.c
Outdated
| errno = EINVAL; | ||
| goto out; | ||
| } | ||
|
|
||
| ret = ctl_exec_query[type](ctx, n, source, arg, indexes); | ||
|
|
||
| char *extra_name = strstr(name, n->name); |
There was a problem hiding this comment.
This do not work correctly. First of all strstr is not "safe"
But also this finds "by_handle" node. So you pass to provider string which beggins from "by_handle" string. In find_node function we already parse ctl string, so you should get the information about when the name string is split, inside of this function
f33f86d to
99c90d5
Compare
ec65bcc to
a749deb
Compare
|
please add ctl.h to docs/config/api.rst |
bratpiorka
reviewed
Feb 21, 2025
bratpiorka
reviewed
Feb 21, 2025
e8e9a64 to
b15e360
Compare
bratpiorka
approved these changes
Feb 21, 2025
346c1af to
b091170
Compare
30c9711 to
7f102c4
Compare
7f102c4 to
210e9a2
Compare
ldorau
approved these changes
Feb 26, 2025
ldorau
reviewed
Feb 26, 2025
|
@lplewa please resolve conversations |
PatKamin
approved these changes
Feb 26, 2025
This commit introduces the control and introspection mechanism that can be accessed using pointer to supported pool or provider.
This commit moves provider_priv and pool_priv members in internal structures due to compatibility issues. From now, adding new ops will not break accessing these members.
210e9a2 to
d319917
Compare
lplewa
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces OS memory provider initial CTL support.
Fixes: #1062
Checklist