add memory properties API #1301
Open
+1,554
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92db71d to
56573df
Compare
a5c357c to
17f6335
Compare
787d15d to
845f2b4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive memory properties API to the unified memory framework, enabling users to query various properties of allocated memory such as memory type, base address, size, and provider-specific information.
- Introduces memory properties API with two main functions:
umfGetMemoryPropertiesHandleandumfGetMemoryProperty - Extends memory provider operations with
ext_get_allocation_propertiesfunction - Adds comprehensive test coverage for the new memory properties functionality
Reviewed Changes
Copilot reviewed 37 out of 38 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| include/umf/base.h | Defines memory property types and handle structures |
| include/umf/experimental/memory_props.h | Public API for memory properties functionality |
| src/memory_props.c | Core implementation of memory properties API |
| src/provider/provider_tracking.c | Updates tracking provider to support memory properties |
| test/props/ | Comprehensive test suite for memory properties API |
| Various provider files | Updates all providers to support new allocation properties interface |
7166723 to
cfae388
Compare
KFilipek
approved these changes
Jul 22, 2025
55cd0ea to
f0d0c8c
Compare
0662923 to
4e1961a
Compare
4e1961a to
4e60061
Compare
lplewa
approved these changes
Aug 7, 2025
0be027c to
a7ca9f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add memory properties API
https://reviewable.io/reviews/bratpiorka/unified-memory-framework/3
fixes #1263