[CTL] Add support for defaults #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bratpiorka merged 2 commits into oneapi-src:main from KFilipek:ctl-default

May 28, 2025

Contributor

KFilipek commented May 19, 2025 •

edited

Loading

Description

Checklist

Code compiles without errors locally
All tests pass locally
CI workflows execute properly


          Add function to get pool name

136dc39

KFilipek self-assigned this

KFilipek requested a review from a team as a code owner

May 19, 2025 09:01

KFilipek added the enhancement label

lukaszstolarczuk mentioned this pull request

[CTL] Add support for defaults #1216

Closed

3 tasks

bratpiorka requested review from lplewa and bratpiorka

May 19, 2025 09:28

lukaszstolarczuk reviewed

View reviewed changes

src/pool/pool_disjoint.c Outdated Show resolved Hide resolved

src/pool/pool_disjoint.c Outdated Show resolved Hide resolved

src/memory_pool.c Outdated Show resolved Hide resolved

include/umf/memory_pool_ops.h Outdated Show resolved Hide resolved

include/umf/memory_pool_ops.h Outdated Show resolved Hide resolved

test/ctl/ctl_api.cpp Outdated Show resolved Hide resolved

test/pools/disjoint_pool.cpp Outdated Show resolved Hide resolved

test/pools/disjoint_pool.cpp Show resolved Hide resolved

test/pools/disjoint_pool_ctl.cpp Outdated Show resolved Hide resolved

test/pools/disjoint_pool_ctl.cpp Outdated Show resolved Hide resolved

lplewa requested changes

View reviewed changes

src/libumf.c Outdated Show resolved Hide resolved

src/memory_pool.c Outdated Show resolved Hide resolved

src/memory_provider.c Show resolved Hide resolved

include/umf/memory_pool_ops.h Outdated Show resolved Hide resolved

src/ctl/ctl.h Outdated Show resolved Hide resolved

lukaszstolarczuk reviewed

View reviewed changes

test/ctl/ctl_unittest.cpp Outdated Show resolved Hide resolved

bratpiorka reviewed

View reviewed changes

src/ctl/ctl.c Show resolved Hide resolved

bratpiorka reviewed

View reviewed changes

src/memory_pool.c Show resolved Hide resolved

bratpiorka reviewed

View reviewed changes

src/pool/pool_disjoint.c Outdated Show resolved Hide resolved

bratpiorka reviewed

View reviewed changes

src/pool/pool_disjoint.c Outdated Show resolved Hide resolved

bratpiorka reviewed

View reviewed changes

test/pools/disjoint_pool.cpp Outdated Show resolved Hide resolved

KFilipek force-pushed the ctl-default branch 6 times, most recently from 3dbf762 to c43ddc7 Compare

May 22, 2025 14:37

KFilipek requested review from lplewa, lukaszstolarczuk and bratpiorka

May 22, 2025 14:37

KFilipek force-pushed the ctl-default branch 6 times, most recently from aec5266 to fe4e66f Compare

May 23, 2025 08:14

KFilipek force-pushed the ctl-default branch from fe4e66f to c051747 Compare

May 23, 2025 09:02

lukaszstolarczuk reviewed

View reviewed changes

include/umf/memory_pool.h Show resolved Hide resolved

include/umf/memory_pool_ops.h Show resolved Hide resolved

src/memory_pool.c Outdated Show resolved Hide resolved

test/ctl/ctl_api.cpp Show resolved Hide resolved

test/ctl/ctl_api.cpp Outdated Show resolved Hide resolved

KFilipek force-pushed the ctl-default branch from c051747 to dfab255 Compare

May 23, 2025 12:29

bratpiorka requested changes

View reviewed changes

src/libumf.c Show resolved Hide resolved

bratpiorka reviewed

View reviewed changes

src/memory_pool.c Outdated Show resolved Hide resolved


          [CTL] Add support for defaults

408069e

KFilipek force-pushed the ctl-default branch from dfab255 to 408069e Compare

May 23, 2025 14:14

KFilipek requested review from bratpiorka and lukaszstolarczuk

May 26, 2025 08:11

bratpiorka approved these changes

View reviewed changes

oneapi-src deleted a comment from lukaszstolarczuk

oneapi-src deleted a comment from lukaszstolarczuk

oneapi-src deleted a comment from lukaszstolarczuk

oneapi-src deleted a comment from lukaszstolarczuk

Contributor

bratpiorka commented May 27, 2025

@lplewa please review

lplewa reviewed

View reviewed changes

src/libumf.c

Comment on lines +124 to +126

+                  // arg can be NULL when executing a command
+                  // ctx can be NULL when executing defaults
+                  // size can depends on the arg

Contributor

lplewa May 27, 2025

NIT: you can check if arg is set then size must be set

lplewa approved these changes

View reviewed changes

Contributor

lplewa left a comment

I did not reviewed test

bratpiorka merged commit 5b85af0 into oneapi-src:main

88 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy