Ctl by name #1471
Open
Ctl by name #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddee327 to
97b61f5
Compare
df6508d to
e99dcd5
Compare
KFilipek
requested changes
Aug 4, 2025
| @@ -111,6 +111,8 @@ umf_result_t umfDisjointPoolParamsSetSharedLimits( | |||
| /// @param hParams handle to the parameters of the disjoint pool. | |||
| /// @param name custom name of the pool. Must not be NULL. Name longer than 63 | |||
| /// characters will be truncated. | |||
| /// \details Name should contain only [a-zA-Z0-9_-] characters. | |||
| /// Other names are deprecated and may limit CTL functionality. | |||
There was a problem hiding this comment.
AFAIK, the \details should also continue indentation in the next lines or bullets
include/umf/memory_pool_ops.h
Outdated
| /// | ||
| /// * The returned name should not exceed 64 characters and may contain |
There was a problem hiding this comment.
64 characters including a line termination character
|
|
||
| static inline void utils_warn_invalid_name(const char *kind, const char *name) { | ||
| if (!utils_name_is_valid(name)) { | ||
| LOG_WARN("%s name \"%s\" is deprecated. It should be no more than 64 " |
bratpiorka
reviewed
Aug 4, 2025
bratpiorka
requested changes
Aug 4, 2025
bratpiorka
reviewed
Aug 5, 2025
bratpiorka
approved these changes
Aug 5, 2025
bratpiorka
requested changes
Aug 5, 2025
eea346b to
43f5e9d
Compare
bratpiorka
approved these changes
Aug 5, 2025
6ddc12a to
6fbd051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://reviewable.io/reviews/lplewa/unified-memory-framework/8