Skip to content

Workaround build failure when building for jemalloc with ninja (#1474) #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

Workaround build failure when building for jemalloc with ninja (#1474) #1476

merged 1 commit into from
Aug 6, 2025

Conversation

blenderfreaky
Copy link

This fixes the issue described in #1474

Description

The CMake code causing the issue now checks whether it's using ninja. If it is, it manually escapes the $ that it fails to escape on its own.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly

@blenderfreaky blenderfreaky requested a review from a team as a code owner August 5, 2025 04:14
@blenderfreaky blenderfreaky changed the base branch from main to v1.0.x August 5, 2025 04:15
@blenderfreaky blenderfreaky mentioned this pull request Aug 5, 2025
Closed
@bratpiorka
Copy link
Contributor

@blenderfreaky UMF uses automatic code format checks, which are failing with your code. Note that the cmake-format package needs to be installed on your system

python -m pip install cmake-format==0.6.13

cmake --build build (...) -DUMF_FORMAT_CODE_STYLE=ON
cmake --build build --target cmake-format-apply

@blenderfreaky
Copy link
Author

@bratpiorka thanks for the help! Rebased to fix the formatting issue

lukaszstolarczuk
lukaszstolarczuk approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@lukaszstolarczuk lukaszstolarczuk merged commit e9fdf33 into oneapi-src:v1.0.x Aug 6, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldorau ldorau ldorau approved these changes

@bratpiorka bratpiorka bratpiorka approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blenderfreaky @bratpiorka @ldorau @lukaszstolarczuk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy