Add a featuregatetest package and module to share featuregate testing support #12377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

bogdandrutu wants to merge 1 commit into open-telemetry:main from bogdandrutu:featuregatetest

Member

bogdandrutu commented Feb 12, 2025

No description provided.

bogdandrutu requested review from a team, mx-psi, dmathieu, evan-bradley, dmitryax and andrzej-stencel as code owners

February 12, 2025 23:30

bogdandrutu force-pushed the featuregatetest branch from 0e048eb to d880b42 Compare

February 12, 2025 23:30

dmitryax approved these changes

View reviewed changes


          Add a featuregatetest package and module to share featuregate testing…

e83c262

… support

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

bogdandrutu force-pushed the featuregatetest branch from d880b42 to e83c262 Compare

February 13, 2025 03:33

codecov bot commented Feb 13, 2025 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.49%. Comparing base (d97904a) to head (e83c262).
Report is 422 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12377      +/-   ##
==========================================
- Coverage   91.49%   91.49%   -0.01%     
==========================================
  Files         466      465       -1     
  Lines       25612    25610       -2     
==========================================
- Hits        23434    23432       -2     
  Misses       1774     1774              
  Partials      404      404

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mx-psi reviewed

View reviewed changes

featuregate/featuregatetest/test_util.go

-              func setFeatureGateForTest(tb testing.TB, gate *featuregate.Gate, enabled bool) {
+              // SetGate sets the value to the given gate. Also, it installs a cleanup function to restore
+              // the gate to the initial value when the test is done.
+              func SetGate(tb testing.TB, gate *featuregate.Gate, enabled bool) {

Member

mx-psi Feb 13, 2025

Why do this instead of using a local registry for testing? I am a bit worried about encouraging this pattern, it modifies global state and it can be hard to reason about

Member Author

bogdandrutu Feb 13, 2025

Any example where I can see what you envision?

Member

mx-psi Feb 13, 2025

I was thinking about some old PR but the idea is not directly applicable here (we no longer have IsEnabled).

I guess the equivalent here for the batch sender tests modified on this PR would be to pass a boolean flag directly to newQueueBatchExporter and set that flag based on the feature gate on the code

mx-psi mentioned this pull request

[service] Add service::telemetry::metrics::views config key #12433

Merged

Contributor

github-actions bot commented Mar 5, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added Stale and removed Stale labels

andrzej-stencel approved these changes

View reviewed changes

Contributor

github-actions bot commented Mar 21, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added Stale and removed Stale labels

mx-psi approved these changes

View reviewed changes

Member

mx-psi left a comment

I don't see a better way of doing this and don't want to block this indefinitely, approving!

Contributor

github-actions bot commented Apr 11, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added Stale and removed Stale labels

Contributor

github-actions bot commented May 1, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added Stale and removed Stale labels

jade-guiton-dd added the ready-to-merge label

Contributor

github-actions bot commented May 17, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added the Stale label

Member

mx-psi commented May 19, 2025

@bogdandrutu we can merge this once the conflicts are resolved

github-actions bot removed the Stale label

Contributor

github-actions bot commented Jun 3, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions bot added Stale and removed Stale labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mx-psi mx-psi approved these changes

dmitryax dmitryax approved these changes

andrzej-stencel andrzej-stencel approved these changes

dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

Labels

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy