[exporter][batcher] Multi-batch support - Version 2 #12760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12760 +/- ##
==========================================
+ Coverage 91.29% 91.30% +0.01%
==========================================
Files 508 509 +1
Lines 28695 28751 +56
==========================================
+ Hits 26196 26252 +56
Misses 1986 1986
Partials 513 513 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2834e5c to
e501416
Compare
46eca7f to
182507f
Compare
jmacd
reviewed
Apr 7, 2025
| } | ||
|
|
||
| func newMultiBatcher(bCfg BatchConfig, bSet batcherSettings[request.Request]) *multiBatcher { | ||
| // TODO: Determine what is the right behavior for this in combination with async queue. |
There was a problem hiding this comment.
What question(s) are there? I'm not sure I'm following.
There was a problem hiding this comment.
This comment is duplicated from newDefaultBatcher(). IIUC, this is related to how goroutines are allocated when async queue and the batcher are used together. Right now:
AsyncQueueowns a goroutine pool of size n that is in charge of reading from the queue and callingBatcher::consume().Batcher::consume()is in charge of appending the new item to the batch and invoking the flushing goroutine if neededBatchercan allocate up to m goroutines for dispatching the active batch.
Both n and m come from the same config field sending_queue::num_consumers, but it does not necessarily make sense use the same number of goroutines for "reading from queue" and "dispatching the request'
0c09d43 to
57c510d
Compare
dmitryax
reviewed
Apr 23, 2025
57c510d to
c33eb25
Compare
e4366df to
dee077d
Compare
c9c5349 to
5c0eaf8
Compare
891c0d1 to
f53126b
Compare
go tidy
4496dd3 to
29d524b
Compare
29d524b to
c206c68
Compare
dmitryax
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two new components
Partitioner- an interface for fetching batch key. A partitioner type should implement the functionGetKey()which returns the batching key.Partitionershould be provided to thequeue_bacheralong withsizerinqueue_batch::Settings.multi_batcher. It supports key-based batching by routing the requests to a correspondingshard_batcher. Eachshard_batchercorresponds to a shard described in Exporter batcher dynamic sharding of the partitions #12473.Link to tracking issue
#12795
Testing
Documentation