Avoid the exporter for being stuck when telemetry data is bigger than batch.max_size #12982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12982 +/- ##
==========================================
- Coverage 91.29% 91.28% -0.01%
==========================================
Files 509 510 +1
Lines 28735 28819 +84
==========================================
+ Hits 26233 26307 +74
- Misses 1988 1996 +8
- Partials 514 516 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmacd
reviewed
May 9, 2025
|
@iblancasa can you please split the PR in two? One fixes the bug, another adds the telemetry |
Sure :) |
a129a87 to
5b46dc5
Compare
dmitryax
reviewed
May 30, 2025
|
@dmitryax the PR is ready for another review |
70aae5f to
16d9ebd
Compare
… batch.max_size Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a bug where the exporter would get stuck when the telemetry data is bigger than batch.max_size. The bug was causing the OpenTelemetry Collector to hang and being OOM Killed at some point.
Link to tracking issue
Fixes #12893