[chore] Fix small nits in persistent queue metadata sizer conversion and add tests #13124
+110
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and add tests Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13124 +/- ##
==========================================
- Coverage 91.60% 91.28% -0.32%
==========================================
Files 505 508 +3
Lines 28526 28661 +135
==========================================
+ Hits 26132 26164 +32
- Misses 1880 1980 +100
- Partials 514 517 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codeboten
approved these changes
Jun 2, 2025
codeboten
reviewed
Jun 2, 2025
exporter/exporterhelper/internal/queuebatch/internal/persistentqueue/sizer_conversion_test.go
Show resolved
Hide resolved
…tqueue/sizer_conversion_test.go Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
dmitryax
approved these changes
Jun 2, 2025
malus2077
pushed a commit
to malus2077/opentelemetry-collector
that referenced
this pull request
Jun 3, 2025
…and add tests (open-telemetry#13124) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.