docs: none values should not take any value #13141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skip changelog 🙏 |
mx-psi
approved these changes
Jun 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13141 +/- ##
=======================================
Coverage 91.26% 91.26%
=======================================
Files 508 508
Lines 28747 28747
=======================================
Hits 26235 26235
Misses 1994 1994
Partials 518 518 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
via the queue into
open-telemetry:main
with commit Jun 4, 2025
0f0e1f6
59 of 75 checks passed
malus2077
pushed a commit
to malus2077/opentelemetry-collector
that referenced
this pull request
Jun 5, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Creating an empty Optional[T] type should not require the value. See: https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/configoptional/optional.go#L109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creating an empty Optional[T] type should not require the value.
See: https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/configoptional/optional.go#L109