[chore] Extract batcher worker pool, cleanup unit tests #13164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d712954 to
8639327
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13164 +/- ##
=======================================
Coverage 91.29% 91.29%
=======================================
Files 509 509
Lines 28735 28737 +2
=======================================
+ Hits 26233 26235 +2
Misses 1988 1988
Partials 514 514 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
auto-merge was automatically disabled
June 5, 2025 20:02
Pull request was converted to draft
8639327 to
79cbb36
Compare
bogdandrutu
commented
Jun 5, 2025
| @@ -36,24 +36,17 @@ type multiBatcher struct { | |||
| var _ Batcher[request.Request] = (*multiBatcher)(nil) | |||
|
|
|||
| func newMultiBatcher(bCfg BatchConfig, bSet batcherSettings[request.Request]) *multiBatcher { | |||
| var workerPool chan struct{} | |||
| if bSet.maxWorkers != 0 { | |||
There was a problem hiding this comment.
maxWorkers cannot be 0, because https://github.com/open-telemetry/opentelemetry-collector/blob/main/exporter/exporterhelper/internal/queuebatch/config.go#L77
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
79cbb36 to
82274c3
Compare
dmitryax
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.