Skip to content

[exporterhelper] Support context marshaling/unmarshaling in the persistent queue #13166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[exporterhelper] Support context marshaling/unmarshaling in the persistent queue #13166

wants to merge 1 commit into from

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Jun 5, 2025 •
edited
Loading

TODOs:

  • Break down into mergable PRs
  • Metadata keys support

@github-actions github-actions bot requested a review from bogdandrutu June 5, 2025 21:56
@dmitryax dmitryax force-pushed the context-marshaling branch 2 times, most recently from e4a0694 to 37f68bb Compare June 5, 2025 22:43
@dmitryax dmitryax changed the title [exporterhelper] Context unmarshaling along with the request [exporterhelper] Support context marshaling/unmarshaling in the persistent queue Jun 5, 2025
@dmitryax dmitryax force-pushed the context-marshaling branch 3 times, most recently from 2a0744c to 73ca69e Compare June 5, 2025 23:24
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.56647% with 44 lines in your changes missing coverage. Please review.

Project coverage is 91.19%. Comparing base (56433bc) to head (6ffc05b).

Files with missing lines Patch % Lines
...xporterhelper/internal/persistentqueue/encoding.go 75.00% 20 Missing and 11 partials ⚠️
pdata/plog/pb.go 0.00% 3 Missing ⚠️
pdata/pmetric/pb.go 0.00% 3 Missing ⚠️
pdata/pprofile/pb.go 0.00% 3 Missing ⚠️
pdata/ptrace/pb.go 0.00% 3 Missing ⚠️
...rterhelper/internal/queuebatch/persistent_queue.go 90.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (74.56%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13166      +/-   ##
==========================================
- Coverage   91.29%   91.19%   -0.11%     
==========================================
  Files         509      511       +2     
  Lines       28737    28892     +155     
==========================================
+ Hits        26235    26347     +112     
- Misses       1988     2020      +32     
- Partials      514      525      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmitryax dmitryax force-pushed the context-marshaling branch from 73ca69e to e0f638f Compare June 5, 2025 23:42
@dmitryax dmitryax mentioned this pull request Jun 6, 2025
Open
@dmitryax dmitryax force-pushed the context-marshaling branch 6 times, most recently from 01aaeee to ce816ce Compare June 6, 2025 16:04
@dmitryax dmitryax force-pushed the context-marshaling branch from ce816ce to 6ffc05b Compare June 6, 2025 18:56
@dmitryax dmitryax mentioned this pull request Jun 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi will be requested when the pull request is marked ready for review mx-psi is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu will be requested when the pull request is marked ready for review dmathieu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmitryax
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy