[configoptional] Make Unmarshal into None[T] match unmarshal into (*T)(nil) #13168
+435
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5cd0415 to
53bdd95
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #13168 +/- ##
==========================================
- Coverage 91.29% 91.28% -0.02%
==========================================
Files 509 509
Lines 28735 28764 +29
==========================================
+ Hits 26233 26256 +23
- Misses 1988 1993 +5
- Partials 514 515 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…one[T] to match unmarshaling into (*T)(nil)
53bdd95 to
e493250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes it so that unmarshaling into a
None[T]is equivalent to unmarshaling into a(*T)(nil).The goal is to be able to do #13109 without introducing any changes to the behavior.
Needs #13161.
Testing
Add a unit test to compare the behavior of unmarshaling into
(*T)(nil)with that of unmarshaling intoNone[T]Documentation