fix(link): remove icon part

ovh · Jul 29, 2024 · 9a9c521 · 9a9c521
1 parent 3484013
commit 9a9c521
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 32 deletions.
diff --git a/packages/ods/src/components/link/src/components/ods-link/ods-link.tsx b/packages/ods/src/components/link/src/components/ods-link/ods-link.tsx
@@ -46,7 +46,11 @@ export class OdsLink {
           </span>
 
           {
-            !!this.icon && <ods-icon part="icon" name={ this.icon } class="ods-link__link__icon"></ods-icon>
+            !!this.icon &&
+            <ods-icon
+              class="ods-link__link__icon"
+              name={ this.icon }>
+            </ods-icon>
           }
         </a>
       </Host>

diff --git a/packages/ods/src/components/link/src/index.html b/packages/ods/src/components/link/src/index.html
@@ -31,23 +31,11 @@
   <ods-link class="my-link" href="test" label="link custom css">
   </ods-link>
 
-  <p>Custom CSS with icon</p>
-  <ods-link class="my-link-icon" href="test" label="link custom css icon" icon="warning">
-  </ods-link>
-
   <style>
     .my-link::part(link) {
       color: green;
       font-size: 32px;
     }
-
-    .my-link-icon::part(link) {
-      font-size: 32px;
-    }
-    .my-link-icon::part(icon) {
-      width: 2rem;
-      height: 2rem;
-    }
   </style>
 </body>
 </html>
diff --git a/packages/storybook/stories/components/link/documentation.mdx b/packages/storybook/stories/components/link/documentation.mdx
@@ -35,12 +35,6 @@ Custom link css:
 
 <Canvas of={ LinkStories.CustomCSSLink } sourceState='shown'/>
 
-You can add your own style on the icon link element using the part `icon`.
-
-Custom icon css:
-
-<Canvas of={ LinkStories.CustomCSSLinkIcon } sourceState='shown'/>
-
 # Examples
 
 ## Usage

diff --git a/packages/storybook/stories/components/link/link.stories.ts b/packages/storybook/stories/components/link/link.stories.ts
@@ -194,16 +194,3 @@ export const CustomCSSLink: StoryObj = {
 </style>
   `,
 }
-
-export const CustomCSSLinkIcon: StoryObj = {
-  tags: ['isHidden'],
-  render: () => html`
-  <ods-link class="my-link-icon" href="/page" label="Content" icon="warning"></ods-link>
-  <style>
-    .my-link-icon::part(icon) {
-      width: 2rem;
-      height: 2rem;
-    }
-  </style>
-  `,
-};