Skip to content

Commit

Permalink
fix(flag): import type first
Browse files Browse the repository at this point in the history
  • Loading branch information
manoncarbonnel authored and dpellier committed Oct 26, 2023
1 parent 60275a9 commit dc83440
Show file tree
Hide file tree
Showing 337 changed files with 1,042 additions and 610 deletions.
1 change: 1 addition & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"error",
{
"groups": [
"type",
"builtin", // Built-in imports (come from NodeJS native) go first
"external", // <- External imports
"internal", // <- Absolute imports
Expand Down
36 changes: 18 additions & 18 deletions packages/cdk/src/components/surface/ocdk-surface-controller.ts
Original file line number Diff line number Diff line change
@@ -1,23 +1,5 @@
import { OcdkAutoLayoutMeasurements } from './core/ocdk-auto-layout-measurements';
import { OcdkSurfaceCornerPointsNormalized } from './core/ocdk-surface-corner-points-normalized';
import { OcdkSurfaceCornerPoints } from './core/ocdk-surface-corner-points';
import { OcdkSurfaceInspections } from './core/ocdk-surface-inspections';
import { OcdkSurfaceAnimationList } from './core/ocdk-surface-animation';
import { OcdkSurfaceStrategyDefiner } from './core/system/ocdk-surface-strategy-definer';
import { OcdkSurfaceInspectionValues } from './core/ocdk-surface-inspection-values';
import {
OcdkSurfaceStrategyInspectorDetails,
OcdkSurfaceStrategyInspectorDetailsFulFilled,
} from './core/system/ocdk-surface-strategy-inspector-details';
import { OcdkSurfaceStrategyAppliers } from './core/system/ocdk-surface-strategy-appliers';
import {
OcdkSurfaceStrategyComputeResultPosition,
isOcdkSurfaceStrategyComputeResultPosition,
} from './core/system/ocdk-surface-strategy-compute-result-position';
import { OcdkSurfaceStrategyComputeResult } from './core/system/ocdk-surface-strategy-compute-result';
import {
isOcdkSurfaceStrategyInspectorsAndAppliers,
} from './core/system/ocdk-surface-strategy-inspectors-and-appliers';
import {
OcdkSurfaceStrategyInspectorComfort,
isOcdkSurfaceStrategyInspectorComfort,
Expand All @@ -35,12 +17,30 @@ import { OcdkSurfaceOnePositionStrategy } from './core/ocdk-surface-one-position
import { OcdkSurfaceConfig } from './core/ocdk-surface-config';
import { OcdkSurfaceCorner } from './core/ocdk-surface-corner';
import { OcdkSurfaceCornerBit } from './core/ocdk-surface-corner-bit';
import { OcdkSurfaceCornerPoints } from './core/ocdk-surface-corner-points';
import { OcdkSurfaceCornerPointsNormalized } from './core/ocdk-surface-corner-points-normalized';
import { OcdkSurfaceDimensions } from './core/ocdk-surface-dimensions';
import { OcdkSurfaceDistance } from './core/ocdk-surface-distance';
import { OcdkSurfaceInspectionValues } from './core/ocdk-surface-inspection-values';
import { OcdkSurfaceInspections } from './core/ocdk-surface-inspections';
import { OcdkSurfaceMaxDimensions } from './core/ocdk-surface-max-dimensions';
import { OcdkSurfaceNormalizedCorner } from './core/ocdk-surface-normalized-corner';
import { OcdkSurfacePoint } from './core/ocdk-surface-point';
import { OcdkSurfaceStrategyAppliers } from './core/system/ocdk-surface-strategy-appliers';
import { OcdkSurfaceStrategyComputeResult } from './core/system/ocdk-surface-strategy-compute-result';
import {
OcdkSurfaceStrategyComputeResultPosition,
isOcdkSurfaceStrategyComputeResultPosition,
} from './core/system/ocdk-surface-strategy-compute-result-position';
import { OcdkSurfaceStrategyDefiner } from './core/system/ocdk-surface-strategy-definer';
import { OcdkSurfaceStrategyDefinerConfig } from './core/system/ocdk-surface-strategy-definer-config';
import {
OcdkSurfaceStrategyInspectorDetails,
OcdkSurfaceStrategyInspectorDetailsFulFilled,
} from './core/system/ocdk-surface-strategy-inspector-details';
import {
isOcdkSurfaceStrategyInspectorsAndAppliers,
} from './core/system/ocdk-surface-strategy-inspectors-and-appliers';
import { OcdkSurface } from './ocdk-surface';
import { OcdkSurfaceAdapter } from './ocdk-surface-adapter';
import { OcdkSurfaceDefaultConfig, ocdkSurfaceCssClasses } from './ocdk-surface-default-config';
Expand Down
1 change: 1 addition & 0 deletions packages/common/stencil/src/config/stencil-config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { Config as JestConfig } from '@jest/types';
import type { Config as StencilConfig } from '@stencil/core';

import { reactOutputTarget } from '@stencil/react-output-target';
import { sass } from '@stencil/sass';
import { vueOutputTarget } from '@stencil/vue-output-target';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import type { GenericLogger } from '../unit/generic-logger';

import { OdsLoggerSpyReferences } from './ods-logger-spy-references';
import { odsMockProperty } from './ods-mock-property';
import { OdsSpyOnLoggerInstance } from './ods-spy-on-logger-instance';
import type { GenericLogger } from '../unit/generic-logger';
import { OdsComponentForTesting } from '../unit/ods-component-for-testing';

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { OdsLoggerMethodSpies } from './ods-logger-method-spies';
import type { GenericLogger } from '../unit/generic-logger';

import { OdsLoggerMethodSpies } from './ods-logger-method-spies';
import { OdsComponentForTesting } from '../unit/ods-component-for-testing';

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { OdsLoggerMethodSpies } from './ods-logger-method-spies';
import type { GenericLogger } from '../unit/generic-logger';

import { OdsLoggerMethodSpies } from './ods-logger-method-spies';

export function OdsSpyOnLoggerInstance(loggerMocked: GenericLogger): OdsLoggerMethodSpies {
return {
log: jest.spyOn(loggerMocked, 'log'),
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { E2EPage } from '@stencil/core/testing';

import { newE2EPage } from '@stencil/core/testing';

describe('e2e:osds-ovh-location-tile', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { E2EElement, E2EPage } from '@stencil/core/testing';

import { newE2EPage } from '@stencil/core/testing';

describe('e2e:osds-ovh-location-tile', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { OdsAccordionGroupController } from './controller';
import type { OdsAccordionAttribute } from '../../osds-accordion/interfaces/attributes';
import type { OdsAccordionToggleEvent } from '../../osds-accordion/interfaces/events';

import { OdsAccordionGroupController } from './controller';
import { OsdsAccordion } from '../../osds-accordion/osds-accordion';
import { OsdsAccordionGroup } from '../osds-accordion-group';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { OdsLogger } from '@ovhcloud/ods-common-core';

import type { OdsAccordionToggleEvent } from '../../osds-accordion/interfaces/events';
import type { OsdsAccordion } from '../../osds-accordion/osds-accordion';
import type { OsdsAccordionGroup } from '../osds-accordion-group';

import { OdsLogger } from '@ovhcloud/ods-common-core';


class OdsAccordionGroupController {
private readonly logger = new OdsLogger('OdsAccordionGroupController');
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { E2EPage } from '@stencil/core/testing';

import { newE2EPage } from '@stencil/core/testing';

describe('e2e:screenshot:osds-accordion-group', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import type { E2EElement, E2EPage } from '@stencil/core/testing';

import { newE2EPage } from '@stencil/core/testing';

describe('e2e:osds-accordion-group', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
jest.mock('./core/controller'); // keep jest.mock before any import

import type { SpecPage } from '@stencil/core/testing';

import { newSpecPage } from '@stencil/core/testing';

import { OdsAccordionGroupController } from './core/controller';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import { Component, Element, Host, Method, h } from '@stencil/core';
import type { OdsAccordionGroupMethod } from './interfaces/methods';
import type { OsdsAccordion } from '../osds-accordion/osds-accordion';
import type { HTMLStencilElement } from '@stencil/core/internal';

import { Component, Element, Host, Method, h } from '@stencil/core';

import { OdsAccordionGroupController } from './core/controller';
import type { OdsAccordionGroupMethod } from './interfaces/methods';
import type { OsdsAccordion } from '../osds-accordion/osds-accordion';


@Component({
tag: 'osds-accordion-group',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import type { OdsAccordionAttribute } from '../interfaces/attributes';

import { ODS_THEME_COLOR_INTENT } from '@ovhcloud/ods-common-theming';

import { ODS_ACCORDION_SIZE } from './accordion-size';
import type { OdsAccordionAttribute } from '../interfaces/attributes';

const DEFAULT_ATTRIBUTE: OdsAccordionAttribute = Object.freeze({
color: ODS_THEME_COLOR_INTENT.info,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import type { OsdsAccordion } from '../osds-accordion';

import { HTMLStencilElement } from '@stencil/core/internal';

import { OsdsAccordionGroup } from '../../osds-accordion-group/osds-accordion-group';
import type { OsdsAccordion } from '../osds-accordion';

class OdsAccordionController {
private component: OsdsAccordion;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { ODS_ACCORDION_SIZE } from '../constants/accordion-size';
import type { ODS_THEME_COLOR_INTENT } from '@ovhcloud/ods-common-theming';

import type { ODS_ACCORDION_SIZE } from '../constants/accordion-size';

interface OdsAccordionAttribute {
/** main color: see component principles */
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import type { OdsAccordionAttribute } from './interfaces/attributes';
import type { E2EElement, E2EPage } from '@stencil/core/testing';

import { odsComponentAttributes2StringAttributes, odsStringAttributes2Str } from '@ovhcloud/ods-common-testing';
import { ODS_THEME_COLOR_INTENT } from '@ovhcloud/ods-common-theming';
import type { E2EElement, E2EPage } from '@stencil/core/testing';
import { newE2EPage } from '@stencil/core/testing';

import { ODS_ACCORDION_SIZES } from './constants/accordion-size';
import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import type { OdsAccordionAttribute } from './interfaces/attributes';



describe('e2e:screenshot:osds-accordion', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import { odsComponentAttributes2StringAttributes, odsStringAttributes2Str } from '@ovhcloud/ods-common-testing';
import type { OdsAccordionAttribute } from './interfaces/attributes';
import type { E2EElement, E2EPage } from '@stencil/core/testing';

import { odsComponentAttributes2StringAttributes, odsStringAttributes2Str } from '@ovhcloud/ods-common-testing';
import { newE2EPage } from '@stencil/core/testing';

import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import type { OdsAccordionAttribute } from './interfaces/attributes';


describe('e2e:osds-accordion', () => {
let page: E2EPage;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
jest.mock('./core/controller'); // keep jest.mock before any import

import type { OdsAccordionAttribute } from './interfaces/attributes';
import type { SpecPage } from '@stencil/core/testing';

import { OdsUnitTestAttributeType, odsComponentAttributes2StringAttributes, odsStringAttributes2Str, odsUnitTestAttribute } from '@ovhcloud/ods-common-testing';
import { ODS_THEME_COLOR_INTENT } from '@ovhcloud/ods-common-theming';
import type { SpecPage } from '@stencil/core/testing';
import { newSpecPage } from '@stencil/core/testing';

import { ODS_ACCORDION_SIZE } from './constants/accordion-size';
import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import { OdsAccordionController } from './core/controller';
import type { OdsAccordionAttribute } from './interfaces/attributes';
import { OsdsAccordion } from './osds-accordion';


Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
import type { ODS_ACCORDION_SIZE } from './constants/accordion-size';
import type { OdsAccordionAttribute } from './interfaces/attributes';
import type { OdsAccordionEvent } from './interfaces/events';
import type { OsdsAccordionGroup } from '../osds-accordion-group/osds-accordion-group';
import type { HTMLStencilElement } from '@stencil/core/internal';

import { ODS_THEME_COLOR_INTENT } from '@ovhcloud/ods-common-theming';
import { ODS_ICON_NAME, ODS_ICON_SIZE } from '@ovhcloud/ods-component-icon';
import { Component, Element, Event, EventEmitter, Host, Prop, Watch, h } from '@stencil/core';
import type { HTMLStencilElement } from '@stencil/core/internal';

import type { ODS_ACCORDION_SIZE } from './constants/accordion-size';

import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import { OdsAccordionController } from './core/controller';
import type { OdsAccordionAttribute } from './interfaces/attributes';
import type { OdsAccordionEvent } from './interfaces/events';
import type { OsdsAccordionGroup } from '../osds-accordion-group/osds-accordion-group';


@Component({
tag: 'osds-accordion',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import type { OdsBreadcrumbItemAttribute } from './interfaces/attributes';
import type { E2EPage } from '@stencil/core/testing';

import { odsComponentAttributes2StringAttributes, odsStringAttributes2Str } from '@ovhcloud/ods-common-testing';
import { ODS_ICON_NAME } from '@ovhcloud/ods-component-icon';
import type { E2EPage } from '@stencil/core/testing';
import { newE2EPage } from '@stencil/core/testing';

import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import type { OdsBreadcrumbItemAttribute } from './interfaces/attributes';


describe('e2e:osds-breadcrumb-item', () => {
const baseAttribute = { href: '', isCollapsed: false, isExpandableItem: false, isLast: false };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import type { OdsBreadcrumbItemAttribute } from './interfaces/attributes';
import type { E2EElement, E2EPage } from '@stencil/core/testing';

import { odsComponentAttributes2StringAttributes, odsStringAttributes2Str } from '@ovhcloud/ods-common-testing';
import { ODS_ICON_NAME } from '@ovhcloud/ods-component-icon';
import type { E2EElement, E2EPage } from '@stencil/core/testing';
import { newE2EPage } from '@stencil/core/testing';

import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import type { OdsBreadcrumbItemAttribute } from './interfaces/attributes';


describe('e2e:osds-breadcrumb-item', () => {
const baseAttribute = { href: '', isCollapsed: false, isExpandableItem: false, isLast: false };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import { odsComponentAttributes2StringAttributes, odsStringAttributes2Str } from '@ovhcloud/ods-common-testing';
import type { OdsBreadcrumbItemAttribute } from './interfaces/attributes';
import type { SpecPage } from '@stencil/core/testing';

import { odsComponentAttributes2StringAttributes, odsStringAttributes2Str } from '@ovhcloud/ods-common-testing';
import { newSpecPage } from '@stencil/core/testing';

import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import type { OdsBreadcrumbItemAttribute } from './interfaces/attributes';
import { OsdsBreadcrumbItem } from './osds-breadcrumb-item';


Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import type { OdsBreadcrumbItemAttribute } from './interfaces/attributes';

import { ODS_THEME_COLOR_INTENT } from '@ovhcloud/ods-common-theming';
import { ODS_ICON_NAME, ODS_ICON_SIZE } from '@ovhcloud/ods-component-icon';
import { Component, Element, Event, EventEmitter, Host, Prop, h } from '@stencil/core';

import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import type { OdsBreadcrumbItemAttribute } from './interfaces/attributes';

/**
* @slot (unnamed) - Breadcrumb Item content
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { OdsLogger } from '@ovhcloud/ods-common-core';
import type { OdsLoggerSpyReferences } from '@ovhcloud/ods-common-testing';

import { OdsLogger } from '@ovhcloud/ods-common-core';
import { OdsClearLoggerSpy, OdsInitializeLoggerSpy } from '@ovhcloud/ods-common-testing';

import { OdsBreadcrumbController } from './controller';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import type { OdsBreadcrumbAttribute } from './interfaces/attributes';
import type { E2EPage } from '@stencil/core/testing';

import { odsComponentAttributes2StringAttributes, odsStringAttributes2Str } from '@ovhcloud/ods-common-testing';
import { ODS_ICON_NAME } from '@ovhcloud/ods-component-icon';
import type { E2EPage } from '@stencil/core/testing';
import { newE2EPage } from '@stencil/core/testing';

import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import type { OdsBreadcrumbAttribute } from './interfaces/attributes';


describe('e2e:osds-breadcrumb', () => {
let page: E2EPage;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import type { OdsBreadcrumbAttributeItem } from './interfaces/attributes';
import type { E2EElement, E2EPage } from '@stencil/core/testing';

import { newE2EPage } from '@stencil/core/testing';

import type { OdsBreadcrumbAttributeItem } from './interfaces/attributes';

describe('e2e:osds-breadcrumb', () => {
const dummyItems = [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
jest.mock('./core/controller'); // keep jest.mock before any

import { odsComponentAttributes2StringAttributes, odsStringAttributes2Str } from '@ovhcloud/ods-common-testing';
import type { OdsBreadcrumbAttribute } from './interfaces/attributes';
import type { SpecPage } from '@stencil/core/testing';

import { odsComponentAttributes2StringAttributes, odsStringAttributes2Str } from '@ovhcloud/ods-common-testing';
import { newSpecPage } from '@stencil/core/testing';

import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import { OdsBreadcrumbController } from './core/controller';
import type { OdsBreadcrumbAttribute } from './interfaces/attributes';
import { OsdsBreadcrumb } from './osds-breadcrumb';


Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import type { OdsBreadcrumbAttribute, OdsBreadcrumbAttributeItem } from './interfaces/attributes';
import type { OdsBreadcrumbItemAttribute } from '../osds-breadcrumb-item/interfaces/attributes';

import { OdsLogger } from '@ovhcloud/ods-common-core';
import { Component, Element, Host, Listen, Prop, State, Watch, h } from '@stencil/core';

import { DEFAULT_ATTRIBUTE } from './constants/default-attributes';
import { OdsBreadcrumbController } from './core/controller';
import type { OdsBreadcrumbAttribute, OdsBreadcrumbAttributeItem } from './interfaces/attributes';
import type { OdsBreadcrumbItemAttribute } from '../osds-breadcrumb-item/interfaces/attributes';


/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import type { OdsButtonAttribute } from '../interfaces/attributes';

import { ODS_THEME_COLOR_INTENT } from '@ovhcloud/ods-common-theming';

import { ODS_BUTTON_SIZE } from './button-size';
import { ODS_BUTTON_TEXT_ALIGN } from './button-text-align';
import { ODS_BUTTON_TYPE } from './button-type';
import { ODS_BUTTON_VARIANT } from './button-variant';
import type { OdsButtonAttribute } from '../interfaces/attributes';


const DEFAULT_ATTRIBUTE: OdsButtonAttribute = Object.freeze({
Expand Down
Loading

0 comments on commit dc83440

Please sign in to comment.
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy