fix: resolve module ipaddr.js correctly when extensionAlias is provided
#228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2486ca6 to
6244ef9
Compare
6244ef9 to
f8ff397
Compare
CodSpeed Performance ReportMerging #228 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
+ Coverage 96.95% 96.97% +0.01%
==========================================
Files 11 11
Lines 2297 2312 +15
==========================================
+ Hits 2227 2242 +15
Misses 70 70 ☔ View full report in Codecov by Sentry. |
JounQin
pushed a commit
that referenced
this pull request
Jul 6, 2025
* chore: update lockfiles * Release v1.9.4 * feat(napi): expose module type info in ResolveResult (#223) * chore: update devDependencies * Release v1.10.0 * fix(napi): update buggy NAPI-RS versions (#225) fix(napi): update buggy @napi-rs/cli * ci: all `--all-features` to various commands * chore(deps): update crate-ci/typos action to v1.23.2 * chore(deps): update rust crate napi to 3.0.0-alpha * chore(deps): update rust crates * ci: add x86_64-unknown-freebsd target (#226) * fix: resolve module `ipaddr.js` correctly when `extensionAlias` is provided (#228) closes #227 * Release v1.10.1 * ci: fix FreeBSD build (#230) * ci: add `needs` check in build-freebsd * ci: publish needs build-freebsd (#232) * Release v1.10.2 * feat: Yarn PnP (#217) Part of #53 * chore(deps): update rust crate napi-derive to 3.0.0-alpha * chore(deps): update rust crates * chore(deps): fix the lock --------- Co-authored-by: Boshen <boshenc@gmail.com> Co-authored-by: LongYinan <lynweklm@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Maël Nison <nison.mael@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #227
Managed to figure this out after stepping through https://github.com/webpack/enhanced-resolve/blob/main/lib/ExtensionAliasPlugin.js