direct: Fix some NameErrors #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"counts" is undeclared in this method, it should loop through "lengths" and print its values.
|
Judging by the name That said, this method has been broken since its inception, so I think the right thing to do is to remove it. I'm assuming it's not being used by anything, right? |
rdb
requested changes
Mar 5, 2018
This has no references inside the engine, and considering that it's been broken since its inception, it's safe to assume that it does not serve any purpose.
|
@rdb Sounds good to me. I was unsure of its exact functionality, but that was my best guess as what it was intended to do. We aren't making any use of it, just happened to stumble across it. I'd also doubt anyone else is making any use of it, except maybe as a simulated crash test case. ;P |
rdb
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rogerrogerin MetaInterval._len2obj. I've implemented this by looping through lengths.