feature #58141: Consistent naming conventions for string dtype aliases #61651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd5e468 to
180d520
Compare
…ype aliases Key implementation steps: - Created factory functions (string, datetime, integer, floating, decimal, boolean, list, categorical, interval, period, sparse, date, duration, map, struct) to generate pandas dtypes (e.g., StringDtype, Int64Dtype, ArrowDtype) based on parameters like backend, bits, unit, and precision. - Added support for both NumPy and PyArrow backends, enabling seamless switching (e.g., integer() returns Int64Dtype for NumPy or ArrowDtype(pa.int64()) for PyArrow). - Implemented parameter validation to ensure correct usage (e.g., validating mode in string() to be "string" or "binary", and unit in datetime() for NumPy). - Integrated PyArrow types for advanced dtypes (e.g., pa.float64(), pa.list_(), pa.map_()), supporting modern data processing frameworks. - Implemented comprehensive tests in test_factory.py to validate dtype creation across all functions, ensuring correct behavior for different backends, verifying string representations (e.g., "double[pyarrow]" for pa.float64()), and confirming proper error handling (e.g., raising ValueError for invalid inputs). - Addressed PyArrow compatibility by implementing correct method calls, such as using pa.bool_() for boolean dtypes, ensuring proper integration. This change simplifies dtype creation, reduces duplication, and ensures compatibility across backends, making it easier to extend support for new dtypes in the future. Co-authored-by: Pedro Santos <pedro.filipe.santos@tecnico.ulisboa.pt>
180d520 to
5f4170d
Compare
c212e3c to
9a60093
Compare
|
@simonjayhawkins Hi! Just wanted to check if this PR needs anything else from my side. Thanks in advance for reviewing |
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key implementation steps:
This change simplifies dtype creation, reduces duplication, and ensures compatibility across backends, making it easier to extend support for new dtypes in the future.
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.