Skip to content

API: offsets.Day is always calendar-day #61985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
+348 −91
Open

API: offsets.Day is always calendar-day #61985

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f1d5bc3
API: offsets.Day is always calendar-day
jbrockmendel Jul 28, 2025
270b859
mypy fixup
jbrockmendel Jul 29, 2025
905bcff
mypy, doc fixup
jbrockmendel Jul 29, 2025
6f46e8d
troubleshoot docbuild
jbrockmendel Jul 29, 2025
6b24e8f
lint ignore
jbrockmendel Jul 29, 2025
39e0c2d
un-split line
jbrockmendel Jul 29, 2025
477f5aa
Avoid passing Day to Timedelta in docs
jbrockmendel Jul 29, 2025
59d3e79
extra newline
jbrockmendel Jul 29, 2025
3a8cd56
typo fixup
jbrockmendel Jul 29, 2025
13e3ffb
whitespace troubleshoot
jbrockmendel Jul 29, 2025
c744b3d
suggested edits
jbrockmendel Jul 30, 2025
a41cdfd
GH ref
jbrockmendel Jul 30, 2025
198ec6c
move nanos check
jbrockmendel Jul 30, 2025
1325c34
Adjust resample expecteds
jbrockmendel Aug 5, 2025
ec15ba1
Merge branch 'main' into daydst3
jbrockmendel Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GH ref
  • Loading branch information
@jbrockmendel
jbrockmendel committed Jul 30, 2025
commit a41cdfd6c52f724926b1e9180cf53b689471dc00
2 changes: 1 addition & 1 deletion pandas/_libs/tslibs/offsets.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,7 +1246,7 @@ cdef class Day(SingleConstructorOffset):
return str(self.n) + "D"
return "D"

# Having this here isn't strictly-correct post-GH#???
# Having this here isn't strictly-correct post-GH#61985
# but this gets called in timedelta.get_unit_for_round in cases where
# Day unambiguously means 24h.
@property
Expand Down
Loading
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy