-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add ASAN support to the zend allocator #18858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danog
wants to merge
48
commits into
php:master
Choose a base branch
from
danog:asan_zend_alloc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
2f84241
ASAN support for the zend allocator
danog 1880729
Fix
danog 193962c
Fix
danog 1a259a0
Fixes
danog 4ea8a03
Fixes
danog ef9a0d2
Fixes
danog 0376092
Improvements
danog 340d985
Improvements
danog e800e53
Improvements
danog 12eefe4
Improvements
danog 6563269
Fix
danog 61661d3
Cleanup
danog 4301651
Cleanup
danog f11d436
Fix
danog bba7468
Fix
danog b1b7c1f
Cleanup
danog 835810c
Cleanup
danog c576965
Fixes
danog e31c4ac
Hotfix newly detected memory leak
danog d9de798
Fixes
danog e5ca924
Fixes
danog e88ec6d
Final
danog dcd59e4
Merge remote-tracking branch 'origin/master' into asan_zend_alloc
danog e1b798a
Update Zend/zend_alloc.c
danog 7b13735
Update Zend/zend_alloc.c
danog 91c783d
Update Zend/zend_alloc.c
danog 66a5172
Update Zend/zend_alloc.c
danog 2178807
cs
danog 085d0c8
Fixup
danog 8925acf
cs fixes
danog 38e7896
cs fixes
danog 1875711
cs fixes
danog 40936ff
Cs fixes
danog 832dae0
cs-fix
danog 1275855
Poison custom chunk_alloc as well
danog 491940e
Unpoison custom chunk_alloc as well
danog 4dd7237
Add comment
danog bebc904
cs
danog 15e2df0
cs
danog 3182c4f
Add some docs
danog 4a30e71
Simplify
danog d944845
Simplify
danog 2f79a43
Fix
danog 541098a
Rm redundant unpoison
danog 3085dc1
Fixup
danog 607cf2b
Fix
danog 587922b
Fix
danog 246b275
Fix
danog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Final
- Loading branch information
commit e88ec6da707d3c0744bf07bfee43bbda46b2abf9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unpoison before
gc()
and repoison after? Also, will there be problems if a customgc
tries to reclaim memory potentially still poisoned?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment explaining why an unpoison is needed.
Also, custom gc's shouldn't have issues what that, as memory isn't poisoned when working with custom heaps (the only parts that are poisoned is the zend_mm_heap structure itself, which of course will not get reclaimed while in use).