streams: Re-add support for arbitrary metadata for stream notifier functions #19158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f91f18 to
551dc7b
Compare
…nctions Support for attaching arbitrary metadata for consumption by stream notifier functions got broken in php#19024 when the previous `zval ptr` got changed to `zend_fcall_info_cache *fcc`, making the data specific to the `user_space_stream_notifier`. Fix this by changing the field to `void *ptr`, avoiding the indirection through a `zval`, but preserving the ability to store arbitrary data. If necessary to support different types than `IS_PTR`, extensions can heap-allocate a `zval` to store within `->ptr` as a minimal change to keep compatibility with PHP 8.4 or lower.
551dc7b to
f1ef6f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for attaching arbitrary metadata for consumption by stream notifier functions got broken in #19024 when the previous
zval ptrgot changed tozend_fcall_info_cache *fcc, making the data specific to theuser_space_stream_notifier.Fix this by changing the field to
void *ptr, avoiding the indirection through azval, but preserving the ability to store arbitrary data. If necessary to support different types thanIS_PTR, extensions can heap-allocate azvalto store within->ptras a minimal change to keep compatibility with PHP 8.4 or lower.