Skip to content

Small optimizations to array_chunk #19190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

Small optimizations to array_chunk #19190

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1803f20
Avoid modulo operation in loop in array_chunk
nielsdos Jul 20, 2025
3931bad
Allocate array eagerly in array_chunk
nielsdos Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Allocate array eagerly in array_chunk 
By preallocating it as a packed array, we save the initial
initialization overhead.
Gives a few extra percentage points improvement.
  • Loading branch information
@nielsdos
nielsdos committed Jul 20, 2025
commit 3931badc0b9b40d3d4e25595f5cd9c2ab7566b0f
1 change: 1 addition & 0 deletions ext/standard/array.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7023,6 +7023,7 @@ PHP_FUNCTION(array_chunk)
}

array_init_size(return_value, (uint32_t)(((num_in - 1) / size) + 1));
zend_hash_real_init_packed(Z_ARRVAL_P(return_value));

ZVAL_UNDEF(&chunk);

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy