Refactor basic time usages #19202
Draft
Refactor basic time usages #19202
+399
−431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c81c27f to
8c044c8
Compare
|
This is related to #19210 |
8c044c8 to
3d9c05a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the internal usages of the current time.
php_time.hto be used instead of systemtime.hphp_realtime_getandphp_realtime_specas a wrapper aroundclock_gettime,timespec_get,gettimeofdayandtimeusing the realtime clockphp_monotime_fallbackeither pointing tozend_hrtimeor wrappingphp_realtime_spectimevalandtimespecphp_*timespecfor current time but keeptimevalfor timeoutsAs a result:
php_realtime_getwill be available for sure because it falls backclock_gettime->timespec_get->gettimeofday->timelongoftimeval.tv_secshould be fixed time() and friends have Y2038 problem on 64 Windows #17856microtime()/gettimeofday(true)without BC breakuniqidrefactored a bit to not wait for the next time but increments if the current time is less or equal to the previous call. This should be faster and resolve a theoretical issue if the real time got modified in between (ntp)Even thought
gettimeofdaymay not be available it wasn't checked everywhere before and compiling would have been failed already if missing. Availability should now be checked but as it falls back and it must have been available before I removed the conditions aroundmicrotime,gettimeofdayanduniqidPS: It's not fully refactored yet but a general pre-review would be welcome.