Upgrade React/Http to v0.8 #271
Conversation
Bridges/BridgeInterface.php
Outdated
| * | ||
| * @return ResponseInterface | ||
| */ | ||
| // public function handle(ServerRequestInterface $request); |
There was a problem hiding this comment.
Just for clarity for me- will remove.
|
@kelunik can I ask you for help here: https://github.com/php-pm/php-pm/pull/271/files#diff-42edefc6558e3945be063a8a1e5019a7R345 ? I'm always getting HTTP 400 back from the slave. Somethings wrong with the way I setup the HTTP Server (or the underlying socket). After banging my head against the wall for two hours now I would appreciate any hep I can get.. |
|
not working yet is UDS on OSX (waiting for react/socket release this weekend, workaround included) and chunked request handling (waiting for react/http merge). |
|
@ALL I can now successfully run a simple non-Symfony application on top of this PR. I have not been able to test Symfony or Laravel and would appreciate some help it order to make progress. These steps are required for testing.
|
|
ping @marcj it doesn't seem like we're getting any test feedback on this one except mine sofar (and I'm not a symfony expert). What's your take on merging this and fixing errors that will be contained going forward? Maybe tag a 0.1 version before merging on all repos and then merge the various contained PRs after cleanup of the VCS aliases? Even though we'll not be on stable react/http versions yet it will at least give us |
|
I'm giving up. Without any testing this PR won't get anywhere :( |
|
@marcj with the requirement changes in react/http ppm is no longer installable. Unless you object I'd merge this and the associated PRs in order to get back to basic installability plus bugfixes going forward. Please let me know if you disagree. |
| "react/socket": "^0.5.0", | ||
| "mkraemer/react-pcntl": "2.0.*", | ||
| "react/stream": "^0.7.1", | ||
| "react/http": "dev-master", |
There was a problem hiding this comment.
I would suggest targeting the specific commit hash until the next release is tagged 👍
There was a problem hiding this comment.
Doesn‘t matter. I‘ll just keep this PR updated until tagged release is available.
|
Rebased and squashed to prepare for merging. All tests are passing now :) |
| if ($config['populate-server-var'] === true && $config['concurrent-requests'] === true) { | ||
| $output->writeln('<error>PPM cannot populate $_SERVER var while processing concurrent requests, disable one of options</error>'); | ||
| exit(1); | ||
| } |
There was a problem hiding this comment.
I think we should just remove concurrent requests, see #268.
| * | ||
| * @var bool | ||
| */ | ||
| protected $populateServer = true; |
There was a problem hiding this comment.
I think this is something the adapter should care about instead?
|
Current exceptions I get: |
|
Except that static file serving (I commented it out to continue testing) everything works great so far in my regular Symfony app. :) |
|
Happy to see this has landed!
We've set up a roadmap with the open issues for the v0.8 release (https://github.com/reactphp/http/milestone/14). We're currently working on resolving the outstanding issues and will evaluate this in one week. If everything goes according to plan, expect the release in the next couple of weeks |
🎉
Follow-up of #226, rebased to current master. Still need to:
RequestHeaderParsercomposer.jsonUnixConnector,ReactSocketnamespace and upgradereact/socket> 0.8.6 (see Support Unix domain socket (UDS) server reactphp/socket#120, has been merged but not released)react/httpto version supporting chunked encoding when it has been released (this is already merged indev-master)pm-psr7/pull/12 and/or Provide default Psr7/Psr-15 and Psr7/invokable bridges plus static web bridge #278)
Supplemented by php-pm/php-pm-httpkernel#63 and php-pm/php-pm-psr7#12
Follow-up topics to be addressed separately (removed todo marker):
react/http0.8 when it has been releasedping @maciejmrozinski