update reactphp event-loop version #386
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not such a good idea. Should probably rather be like in https://github.com/reactphp/socket/blob/master/composer.json#L10 |
|
@andig but |
|
Then thats one more reason to keep supporting 0.4. plus mkraemer could probably use a pr ;) |
|
react/event-loop 0.5 added signal handling reactphp/event-loop#104 so is mkraemer/react-pcnt even needed anymore? |
andig
reviewed
Jun 11, 2018
| @@ -8,7 +8,7 @@ | |||
| "symfony/console": "^2.6|^3.0|^4.0", | |||
| "symfony/debug": "^2.6|^3.0|^4.0", | |||
| "symfony/process": "^2.6|^3.0|^4.0", | |||
| "react/event-loop": "^0.4", | |||
| "react/event-loop": "^0.5", | |||
There was a problem hiding this comment.
As per previous comments that breaks the installation and is not acceptable.
Good idea- but then is is a prerequisite for upgrading event-loop to 0.5. |
|
Replaced by #390 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable ext-ev php extension