Skip to content

feat: set APP_RUNTIME_MODE for frankenphp-symfony #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Oct 26, 2023

@alexander-schranz
Copy link
Member

alexander-schranz commented Oct 26, 2023

I think we need to define this for all other Symfony Runtimes also or is frankenphp the only when where the autodection does not work? If we need define it for all Symfony runtimes, does somebody has the correct insides what the correct values for specific runtimes are?

If example Roadrunner does web requests but little bit different as FrankenPHP as it runs PHP from Roadrunner GO Server via CLI context as I know. Would it be still the 'web=1&worker=1' or would it be in that case 'web=0&worker=1'?

PS: Psalm & Composer normalized are fixed on main.

@dunglas
Copy link
Contributor Author

dunglas commented Oct 27, 2023

This must be done for all runtimes but I'm not sure of the value to use for web. It should probably be set to 1 everywhere is errors are generated as HTML. cc @nicolas-grekas

@dunglas dunglas force-pushed the feat/frankenphp-APP_RUNTIME_MODE branch from 2a50799 to 2603c47 Compare October 30, 2023 08:19
@alexander-schranz alexander-schranz merged commit 3e665c7 into php-runtime:main Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy