Skip to content

Commands should always return int #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2019
Merged

Commands should always return int #347

merged 1 commit into from
Nov 25, 2019

Conversation

odolbeau
Copy link
Member

All commands must return an integer.
See symfony/symfony#33775

@XWB
Copy link
Contributor

XWB commented Nov 23, 2019

👍

@XWB
Copy link
Contributor

XWB commented Nov 24, 2019

@odolbeau Now that #348 is merged, can you rebase so we can validate the unit tests?

@odolbeau
Copy link
Member Author

@XWB Done! 👍

@welcoMattic
Copy link
Member

Thanks @odolbeau 👍

@welcoMattic welcoMattic merged commit f96c7cd into php-translation:master Nov 25, 2019
@odolbeau odolbeau deleted the update-commands branch November 25, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welcoMattic welcoMattic welcoMattic approved these changes

@rvanlaak rvanlaak rvanlaak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odolbeau @XWB @welcoMattic @rvanlaak
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy