-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Task]: Fix broken tests #17255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Fix broken tests #17255
Conversation
Review Checklist
|
Can you please check if symfony/symfony#57615 fixes your tests? |
@derrabus Thank you for coming by, but i can't test it because it's likely unrelated (fails with 7.1.1) to that. |
No idea why but the latest bugfix release of symfony/http-client breaks our tests |
@markus-moser You mean The PR symfony/symfony#57372 is too old. Then the tests must have failed for 2 weeks (there is a 6.4.x test). |
@blankse Yes I also thought that this PR can be the only reason. |
@markus-moser I can confirm that it is this PR. When I locally revert these changes, the tests run correctly. |
Maybe is the error here: |
Thanks for the hint - yes this sounds like it could be the cause of the problem |
|
It's a bit weird but works now. The fallback language was not actually defined in the system settings of the tests. So it only worked by some kind of side effect. Maybe because of the order of the tests and this configuration change in the localized field test
|
If the HttpKernel change causes issues, could you please check if symfony/symfony#57593 is of any help? |
@xabbuh Thanks for your hint but we found out that a problem in our test setup was the root cause of the problem. |
Seems related to symfony/symfony#57612