Skip to content

[Task]: Fix broken tests #17255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 1, 2024
Merged

[Task]: Fix broken tests #17255

merged 22 commits into from
Jul 1, 2024

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Jul 1, 2024

Seems related to symfony/symfony#57612

Copy link

github-actions bot commented Jul 1, 2024

Review Checklist

  • Target branch (11.2 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@derrabus
Copy link

derrabus commented Jul 1, 2024

Can you please check if symfony/symfony#57615 fixes your tests?

@kingjia90
Copy link
Contributor Author

kingjia90 commented Jul 1, 2024

@derrabus Thank you for coming by, but i can't test it because it's likely unrelated (fails with 7.1.1) to that.
It still seems related to some "regression" in the latest release, because our lowest tests are working fine, but highest started failing in these 3 days which matches with the latest symfony bugfix release

@markus-moser
Copy link
Contributor

No idea why but the latest bugfix release of symfony/http-client breaks our tests

@blankse
Copy link
Contributor

blankse commented Jul 1, 2024

@markus-moser You mean symfony/http-kernel
It must be this PR then: symfony/symfony#57553

The PR symfony/symfony#57372 is too old. Then the tests must have failed for 2 weeks (there is a 6.4.x test).

@markus-moser
Copy link
Contributor

@blankse Yes I also thought that this PR can be the only reason.

@blankse
Copy link
Contributor

blankse commented Jul 1, 2024

@markus-moser I can confirm that it is this PR. When I locally revert these changes, the tests run correctly.

@blankse
Copy link
Contributor

blankse commented Jul 1, 2024

Maybe is the error here:
https://github.com/pimcore/pimcore/blob/11.x/lib/Translation/Translator.php#L390
The internal translator has a new second argument $buildDir

@markus-moser
Copy link
Contributor

https://github.com/pimcore/pimcore/blob/11.x/lib/Translation/Translator.php#L390

Thanks for the hint - yes this sounds like it could be the cause of the problem

Copy link

sonarqubecloud bot commented Jul 1, 2024

@markus-moser
Copy link
Contributor

It's a bit weird but works now.

The fallback language was not actually defined in the system settings of the tests. So it only worked by some kind of side effect. Maybe because of the order of the tests and this configuration change in the localized field test

\Pimcore\Config::setSystemConfiguration($configuration);

@markus-moser markus-moser marked this pull request as ready for review July 1, 2024 16:21
@markus-moser markus-moser merged commit f1fa051 into 11.2 Jul 1, 2024
18 checks passed
@markus-moser markus-moser deleted the fix-tests branch July 1, 2024 16:21
@xabbuh
Copy link
Contributor

xabbuh commented Jul 1, 2024

If the HttpKernel change causes issues, could you please check if symfony/symfony#57593 is of any help?

@markus-moser
Copy link
Contributor

@xabbuh Thanks for your hint but we found out that a problem in our test setup was the root cause of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy