Move nano specs hack into our module cmake files. #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been maintaining a downstream patch to disable C++ exception handling, which gives us some headroom before our builds get too big and overwrite themselves at runtime. Forgetting to apply this patch is a constant source of debugging frustration. It turns out it can just be added to our USER_C_MODULES cmake files instead, where it will implicitly be included when building against our modules.
|
🤞 for CI pass. It's messy, but a lot less hassle to maintain (since the patch breaks every time the MicroPython port CMakeLists changes) can't believe I didn't think of this sooner... |
|
I much prefer it's done this way than permanently applying these settings into the main rp2 CMakeLists.txt file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been maintaining a downstream patch to disable C++ exception handling, which gives us some headroom before our builds get too big and overwrite themselves at runtime.
Forgetting to apply this patch is a constant source of debugging frustration. It turns out it can just be added to our USER_C_MODULES cmake files instead, where it will implicitly be included when building against our modules.