[WIP] View all articles filter | Change "View All" posts pages to search page #1337
+9
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ckhackshaw is attempting to deploy a commit to the OceanBit Team on Vercel. A member of the Team first needs to authorize it. |
4c5be23 to
3fba384
Compare
|
@fennifith I have made the changes discussed in the issue, I have yet to do the following:
Just confirming that this is what you wanted, and that I should go ahead and delete the above files |
|
@ckhackshaw Yep, that's correct! It might also be a good idea to add a redirect from |
fennifith
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1281
Here's what I have done so far.
As I commented in the issue, this solution adds the filter bar to the "View All" articles page.
I will have to add a lot of the functionality for the filter barthat already exists on the search page. Considering DRY principle, I am thinking that I would probably have to extract some to hooks.
That's why I was wondering if the idea was to use a simple link as is used for the "View All" Collections button (https://playfulprogramming.com/search?q=*&display=collections).
I had assumed the feature request was based on the last comment from @jessi-z3.