Update base.py to remove setuptools and use standard library #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoghaddam385
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the method for retrieving the version number of the
polygon-api-clientpackage. It replaces the use ofpkg_resourcesfromsetuptoolswithimportlib.metadata, which is part of the standard library in Python 3.8 and newer.Changes
import pkg_resourcesand replaced it withfrom importlib.metadata import version, PackageNotFoundError.importlib.metadata.versioninstead ofpkg_resources.require.Benefits
setuptoolswhich is deprecated and causing issues (pkg_resources is deprecated as an API #693 & setuptools is a requirement #593)