Skip to content

Dont crash the dashboard if search index is not built #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2023
Merged

Dont crash the dashboard if search index is not built #1018

merged 2 commits into from
Sep 17, 2023

Conversation

levkk
Copy link
Contributor

@levkk levkk commented Sep 16, 2023 •
edited
Loading

  1. This is kinda annoying since while really important, searching is not the only functionality the app provides, so if we don't have the search index built for any reason, we should not just crash.
  2. Useful for testing. The search index is not necessary for tests and it's a bit time consuming to build for each integration test.

@levkk levkk changed the title Dont crash the app if search index is not built Dont crash the dashboard if search index is not built Sep 16, 2023
@levkk levkk marked this pull request as ready for review September 17, 2023 16:24
@levkk levkk merged commit c41340b into master Sep 17, 2023
@levkk levkk deleted the levkk-empty-search-index branch September 17, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@levkk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy