Skip to content

add careers #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 27, 2023
Merged

add careers #1176

merged 9 commits into from
Nov 27, 2023

Conversation

montanalow
Copy link
Contributor

@montanalow montanalow commented Nov 20, 2023

Also fixes #1174

@montanalow montanalow force-pushed the montana/cms branch 9 times, most recently from e6e62cc to 1dbc7a6 Compare November 26, 2023 20:54
@montanalow montanalow marked this pull request as ready for review November 26, 2023 21:55
Copy link
Contributor Author

@montanalow montanalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of additional cleanup todo in follow up PRs

@levkk
Copy link
Contributor

levkk commented Nov 26, 2023

Do you have a changelog?

@montanalow
Copy link
Contributor Author

montanalow commented Nov 27, 2023

Most of these changes are the beginnings to cleanup the 3 splits we have of doing things.

  • Move all of content to gitbook (fix navs, relative and absolute urls)
    • unnest docs/guides into just guides
  • refactor config to use static variables, instead of recomputing every call
  • Replace comrak with markdown (replace mkdocs with gitbook flavor markdown)
  • Replace templates with components (Collection & Document)... Collection and Document can take us a lot further, but IndexLink should become part of Collection

Further TODO:

  • Design
    • Fonts
      • Heading Sizes
        • H2 is too big
          • Frequently wraps
          • Looks off with short sections like the blog “Have Questions”/“Try it Out” footer
        • H3 is too big
        • H4/5/6 are not differentiated enough
    • Bold isn’t very noticeable (make it brighter or heavier?)
    • Tabs need a bottom border or divider, it’s unclear where the tab content stops
    • Images - Update all graphs/images with consistent visual style
      • Rounded or Square corners? Border/Glow/Shadow?
      • FigCaption needs a style. Italic/dimmer/smaller.
      • FigCaption is currently wider than some images
  • Marketing
    • Write a style guide, and implement it
      • Standardize emoji use?
      • Headings: title or camelcase?
    • Blog Post Review Checklist
      • SEO keywords in title
      • Description
      • Image
      • Author
      • Date
    • Documentation Review Checklist
  • Engineering
    • Search should be our implementation
      • Indexing should reuse the same markdown traversing/parsing/rendering logic
    • Codeblocks
      • Cleanup code block markdown syntax, “improper” use generates inconsistent views of code on the blog
      • Syntax highlighting should be codemirror everywhere
    • Interactable ToC
      • Bug: Table of Contents active highlight only works if header is on screen
    • 404 should still show the index links of the collection
    • Finish refactor from ResponseOK/BadRequest/NotFound() etc, to Response::ok(), Response::bad_request() etc

@montanalow montanalow merged commit f27697e into master Nov 27, 2023
@montanalow montanalow deleted the montana/cms branch November 27, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs link 404's
2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy