Skip to content

Added OpenSourceAI and conversational support in the extension #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Dec 1, 2023
Merged

Added OpenSourceAI and conversational support in the extension #1206

merged 22 commits into from
Dec 1, 2023

Conversation

SilasMarvin
Copy link
Contributor

No description provided.

@SilasMarvin SilasMarvin requested a review from levkk November 29, 2023 23:16
@levkk
Copy link
Contributor

levkk commented Nov 29, 2023 •
edited
Loading

🚀 🌔 🏆

Quick question re: API change from String to JsonB for the transform_stream, is that backwards compatible? I don't suppose we have a lot of adoption of those new methods yet since we haven't actually released 2.8.0 yet "officially", but still would be nice to keep those working if we can.

@SilasMarvin
Copy link
Contributor Author

🚀 🌔 🏆

Quick question re: API change from String to JsonB for the transform_stream, is that backwards compatible? I don't suppose we have a lot of adoption of those new methods yet since we haven't actually released 2.8.0 yet "officially", but still would be nice to keep those working if we can.

It is a breaking change unfortunately. It was a bad choice on my side to make it a string. I spoke with Montana about it, and it hasn't been released and I'm the only one using it so not too worried. Before we ship and merge this I need to make adjustments to our frontend or it will break something though

@levkk
Copy link
Contributor

levkk commented Nov 30, 2023

Sounds good!

levkk
levkk reviewed Nov 30, 2023
View reviewed changes
@SilasMarvin SilasMarvin merged commit 0be25d0 into master Dec 1, 2023
@SilasMarvin SilasMarvin deleted the silas-open-source-ai-better-rebase branch December 1, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levkk levkk levkk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SilasMarvin @levkk
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy