Allow user to limit the number of threads that OpenMP spawns. #1362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Managing GUC parameters in different places is hard to maintain. This patch organizes GUC definitions in a single place. Also, we use define_xxx_guc() APIs to define these parameters and it will allow us to manage GucContext, GucFlags in future. P.S., the test case test_trusted_model doesn't seem correct. I fixed it in this patch.
This patch introduces a new GUC parameter pgml.omp_num_threads to control control the number of threads that OpenMP can spawn. Co-authored-by: Xuebin Su <sxuebin@vmware.com> Co-authored-by: Xuebin Su (苏学斌) <12034000+xuebinsu@users.noreply.github.com>
kczimm
suggested changes
Apr 4, 2024
pgml-extension/Cargo.toml
Outdated
| @@ -49,6 +49,7 @@ serde = { version = "1.0" } | |||
| serde_json = { version = "1.0", features = ["preserve_order"] } | |||
| typetag = "0.2" | |||
| xgboost = { git = "https://github.com/postgresml/rust-xgboost", branch = "master" } | |||
| lazy_static = "1.4.0" | |||
There was a problem hiding this comment.
We can use the once_cell::sync::Lazy since we already have that dependency, rather than adding a new one.
kczimm
approved these changes
Apr 5, 2024
e909ac5 to
3768179
Compare
kczimm
suggested changes
Apr 10, 2024
pgml-extension/src/lib.rs
Outdated
| #[cfg(not(feature = "use_as_lib"))] | ||
| #[pg_guard] | ||
| pub extern "C" fn _PG_init() { | ||
| config::initialize_server_params(); | ||
| let omp_num_threads = config::PGML_OMP_NUM_THREADS.get(); |
There was a problem hiding this comment.
I think we should move this get/set into the config::initialize_server_params() also. It's specifically configuration.
kczimm
suggested changes
Apr 10, 2024
Co-authored-by: kczimm <4733573+kczimm@users.noreply.github.com>
Co-authored-by: kczimm <4733573+kczimm@users.noreply.github.com>
- Set the minimum value of OMP_NUM_THREADS to 1. - Move PGML_OMP_NUM_THREADS.get() into initialize_server_params().
No problem! Glad to hear more suggestions from you :-) |
kczimm
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a new GUC parameter pgml.omp_num_threads to
control control the number of threads that OpenMP can spawn.
This PR contains 2 commits. The first one is refactoring the GUC parameters of pgml (#1360). The second one is for allowing user to control the number of threads that OpenMP can spawn.
Fixes #1161
Depends on #1360 which helps manage GUC parameters better.