Skip to content

Data docs #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 24, 2024
Merged

Data docs #1418

merged 12 commits into from
Apr 24, 2024

Conversation

levkk
Copy link
Contributor

@levkk levkk commented Apr 24, 2024

Features

  1. Fork @codemirror/lang-sql to add support for Postgres-specific syntax.
  2. Change docs text color to white.
  3. Markdown tables in docs are now .table-sm by default instead of the ugly default bootstrap tables.
  4. Add anchor (link) support for headings/table of contents markdown parser.
  5. Add padding to the bottom of the code block to offset horizontal scrolling bar.

Documentation

  1. Documented logical replication, FDWs, and COPY in data import.

@levkk levkk requested a review from chillenberger April 24, 2024 16:22
Copy link
Contributor

@montanalow montanalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -50,7 +51,7 @@

## Product

* [Cloud Database](product/cloud-database/README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Cloud as opposed to Vector section

@@ -79,7 +80,7 @@
## Resources

* [FAQs](resources/faqs.md)
* [Data Storage & Retrieval](resources/data-storage-and-retrieval/README.md)
* [Data Storage & Retrieval](resources/data-storage-and-retrieval/tabular-data.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dup?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a dup, README.md is currently empty.

@@ -4,11 +4,11 @@ description: Setup a database and connect your application to PostgresML

# Getting Started

A PostgresML deployment consists of multiple components working in concert to provide a complete Machine Learning platform. We provide a fully managed solution in our cloud.
A PostgresML deployment consists of multiple components working in concert to provide a complete Machine Learning platform. We provide a fully managed solution in our cloud, and document a self-hosted installation in our docs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documenting the self hosted version is confusing here. Are these docs for cloud users, or self hosted people?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both.

* A web application to manage deployed models and host SQL notebooks
* PostgreSQL database, with `pgml`, `pgvector` and many other extensions installed, including backups, metrics, logs, replicas and high availability
* PgCat pooler to provide secure access and model load balancing across thousands of clients
* A web application to manage deployed models and write experiments in SQL notebooks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* A web application to manage deployed models and write experiments in SQL notebooks
* A web application to manage deployed models and share experiments and analysis in SQL notebooks


## Application SDKs
## SDK
Copy link
Contributor

@montanalow montanalow Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## SDK
## Client SDKs

We've waffled between singular and plural. If we want to change to singular, we'll need to update in several other places, including urls.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to write Client SDKs ever again, that wording is just wrong. SDK are only usable on the client by definition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going to be singular going forward.

Copy link
Contributor

@montanalow montanalow Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New PRs should use the existing style guide, for code or copy. We should make that update globally in a separate PR to preserve consistency.

Dealing with the separate issue, many users frequently ask about the difference between the SDK and Extension, and how they interact. I think you're confused about the difference between and SDK and API as commonly used, but those terms are not always 100% consistently used in industry, so we need some additional education about how we're using them.


These SDKs are under rapid development to add new features and use cases, but we release non breaking changes with minor version updates in accordance with SemVer. It's easy to install into your existing application.
The SDK are under rapid development to add new features and use cases, but we release non breaking changes with minor version updates in accordance with SemVer. It's easy to install into your existing application.
Copy link
Contributor

@montanalow montanalow Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The SDK are under rapid development to add new features and use cases, but we release non breaking changes with minor version updates in accordance with SemVer. It's easy to install into your existing application.
The SDKs are under rapid development to add new features and use cases, but we release non breaking changes with minor version updates in accordance with SemVer. It's easy to install into your existing application.

@@ -28,6 +28,8 @@ pip install pgml
{% endtab %}
{% endtabs %}

Our SDK comes with zero additional dependencies. The core of the SDK is written in Rust, and we provide language bindings and native packaging & distribution.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Our SDK comes with zero additional dependencies. The core of the SDK is written in Rust, and we provide language bindings and native packaging & distribution.
Our SDK comes with zero additional dependencies, to provide the simplest and safest ML application deployment and maintenance possible. The core of the SDK is written in Rust, and we provide language bindings and native packaging & distribution.


Use any of these popular tools to execute SQL queries directly against the database:
If you need to write ad-hoc queries, you can use any of these popular tools to execute SQL queries directly on your database:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you need to write ad-hoc queries, you can use any of these popular tools to execute SQL queries directly on your database:
If you need to write ad-hoc queries, or perform administrative functions, you can use any of these popular tools to execute SQL queries directly on your database:


Data that changes infrequently can be easily imported into PostgresML using `COPY`. All you have to do is export your data as a CSV file, create a table in Postgres to store it, and import it using the command line.
If you're intention is to use PostgresML as your primary database, your job here is done. You can use the connection credentials provided and start building your application on top of in-database AI right away.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you're intention is to use PostgresML as your primary database, your job here is done. You can use the connection credentials provided and start building your application on top of in-database AI right away.
If your intention is to use PostgresML as your primary database, your job here is done. You can use the connection credentials provided and start building your application on top of in-database AI right away.

if let NodeValue::Text(text) = &sibling.data.borrow().value {
let index = match header_count.get(text) {

println!("child: {:?}", sibling);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
println!("child: {:?}", sibling);

@@ -79,7 +80,7 @@
## Resources

* [FAQs](resources/faqs.md)
* [Data Storage & Retrieval](resources/data-storage-and-retrieval/README.md)
* [Data Storage & Retrieval](resources/data-storage-and-retrieval/tabular-data.md)
* [Tabular data](resources/data-storage-and-retrieval/tabular-data.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Tabular data](resources/data-storage-and-retrieval/tabular-data.md)

Copy link
Contributor

@chillenberger chillenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if let NodeValue::Text(text) = &sibling.data.borrow().value {
let index = match header_count.get(text) {

println!("child: {:?}", sibling);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want this println in here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not :) good catch

@levkk levkk marked this pull request as draft April 24, 2024 17:09
@levkk levkk marked this pull request as ready for review April 24, 2024 21:43
@levkk levkk merged commit 82dc23f into master Apr 24, 2024
@levkk levkk deleted the levkk-more-docs branch April 24, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy