make session backwards compatible #1528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levkk
reviewed
Jun 17, 2024
| // Get the notification that triggered this call. | ||
| // Guaranteed to exist since it built the component that called this, so this is safe to unwrap. | ||
| // Get the notification that triggered this call.. | ||
| // unwrap notifications if fine since we should panic if this is missing. |
There was a problem hiding this comment.
We should not be panicking if anything optional like this is missing. We should default to vec![].
levkk
reviewed
Jun 17, 2024
| ]; | ||
|
|
||
| let response = client | ||
| .get("/notifications/product/modal/remove_modal?id=1") |
There was a problem hiding this comment.
This feels like the wrong place to implement this. This should be in our web app, and we should pass it through the context into the dashboard.
There was a problem hiding this comment.
Not sure what you mean here. The test, or the endpoint should be in web app? I felt like both are needed here since notifications include marketing notifications.
chillenberger
added a commit
that referenced
this pull request
Jun 17, 2024
This reverts commit 23b243b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.