Scikit hyperparameter search #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montanalow
reviewed
Sep 20, 2022
| @@ -81,7 +81,7 @@ CREATE TABLE IF NOT EXISTS pgml_rust.models( | |||
| hyperparams JSONB NOT NULL, | |||
| status TEXT NOT NULL, | |||
| metrics JSONB, | |||
| search pgml_rust.search, | |||
There was a problem hiding this comment.
This should stay as an enum value, you can convert to_string() in the call to scikit.
There was a problem hiding this comment.
That doesn't work, it gives me an error about not finding the type. I don't know why but enums are a pain.
There was a problem hiding this comment.
The other enums work, you just have to cast to TEXT on the in and out. We don't have the OID for them AFAIK, although pgx might know better.
There was a problem hiding this comment.
It's probably the nullable property that's causing this then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.