Skip to content

Development dockerfile #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 5, 2023
Merged

Development dockerfile #685

merged 3 commits into from
Jun 5, 2023

Conversation

jsaied99
Copy link
Contributor

@jsaied99 jsaied99 commented Jun 5, 2023

Fixing Dockerfile.local for local development. To run it you can do:

docker compose -f docker-compose.local.yml build --build-arg PG_MAJOR_VER=14
docker compose -f docker-compose.local.yml up

@jsaied99 jsaied99 marked this pull request as ready for review June 5, 2023 17:03
montanalow
montanalow approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@montanalow montanalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great improvement. I think the next step will be to also create a distinction between local and packaged versions of pgml-dashboard to mirror the extension, and then update our packaging github actions, so we're consistent all the way.

@montanalow montanalow merged commit dcafbe6 into postgresml:master Jun 5, 2023
SilasMarvin pushed a commit that referenced this pull request Oct 5, 2023
@jsaied99
Development dockerfile (#685)
448b10b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montanalow montanalow montanalow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsaied99 @montanalow
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy