Dan set user #697
Merged
Dan set user #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levkk
reviewed
Jun 6, 2023
| @@ -46,17 +47,31 @@ impl<'r> FromRequest<'r> for Cluster { | |||
| None => -1, | |||
| }; | |||
|
|
|||
| let shared_state = match request.guard::<&State<Clusters>>().await { | |||
| let user_id: i64 = match cookies.get_private("user_id") { | |||
There was a problem hiding this comment.
Suggested change
| let user_id: i64 = match cookies.get_private("user_id") { | |
| let user_id = match cookies.get_private("user_id") { |
There was a problem hiding this comment.
Also we are setting this object in our closed source code, you don't need to fetch the cookie here. The cookie won't provide enough user information once we start adding more, e.g. email.
levkk
reviewed
Jun 6, 2023
| Outcome::Success(pool) => pool, | ||
| _ => return Outcome::Forward(()), | ||
| }; | ||
|
|
||
| let pool = shared_state.get(cluster_id); | ||
| let pool = clusters_shared_state.get(cluster_id); | ||
|
|
||
| let context = Context { |
There was a problem hiding this comment.
Isn't Context an exported public struct of this app? If not, it should be, so we instantiate it and set it in our code.
levkk
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In guards, get user from saved cookie rather than cluster owner. This ensures even if cluster is not chosen the user is known for rendering top nav.