-
Notifications
You must be signed in to change notification settings - Fork 87
[PBCKP-259] fix for 'ERROR: Cannot create directory for older backup'… #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, rewrite --start_time implementation Rewritten 5f2283c Fixed: * tests.backup.BackupTest.test_issue_231 * tests.restore.RestoreTest.test_restore_chain * tests.restore.RestoreTest.test_restore_backup_from_future Not yet fixed: * tests.restore.RestoreTest.test_restore_chain_with_corrupted_backup * tests.merge.MergeTest.test_merge_backup_from_future
…ncorrect_time fix
…re and tests.restore.RestoreTest.test_restore_backup_from_future as incorrect for now
… can be performed with start-time option. Fix checking that time of new backup later, than latest existing backup
935ff84
to
2f8d5ef
Compare
…test_start_time_few_nodes
…rmissions for ptrack and PG-11
* tests.backup.BackupTest.test_backup_detect_corruption * tests.backup.BackupTest.test_backup_detect_invalid_block_header
funny-falcon
pushed a commit
that referenced
this pull request
Oct 14, 2022
#526) * [PBCKP-259] fix for 'ERROR: Cannot create directory for older backup', rewrite --start_time implementation * rewritten 5f2283c * fixes for several tests * disabled tests.merge.MergeTest.test_merge_backup_from_future and tests.restore.RestoreTest.test_restore_backup_from_future as incorrect for now Co-authored-by: d.lepikhova <d.lepikhova@postgrespro.ru>
kulaginm
added a commit
to pgtoolz/pg_backup
that referenced
this pull request
Mar 25, 2023
… backup'… (postgrespro#526)" This reverts commit 1bb0762.
kulaginm
added a commit
to pgtoolz/pg_backup
that referenced
this pull request
Mar 25, 2023
* Revert "[PBCKP-259] fix for 'ERROR: Cannot create directory for older backup'… (postgrespro#526)" This reverts commit 1bb0762. * Revert "Add warning about using --start-time option" This reverts commit 8ce27c9. * Revert "Add tests for --start-time option on the one and few nodes" This reverts commit 1b75b4e. * Revert "Add --start-time option for backup" This reverts commit 3c74ebf. * Revert "Add backup start time as parameter for do_backup" This reverts commit 5f2283c. * Remove --start-time option
gsmolk
pushed a commit
to pgtoolz/pg_backup
that referenced
this pull request
Mar 25, 2023
* Revert "[PBCKP-259] fix for 'ERROR: Cannot create directory for older backup'… (postgrespro#526)" This reverts commit 1bb0762. * Revert "Add warning about using --start-time option" This reverts commit 8ce27c9. * Revert "Add tests for --start-time option on the one and few nodes" This reverts commit 1b75b4e. * Revert "Add --start-time option for backup" This reverts commit 3c74ebf. * Revert "Add backup start time as parameter for do_backup" This reverts commit 5f2283c. * Remove --start-time option
gsmolk
pushed a commit
to pgtoolz/pg_backup
that referenced
this pull request
Apr 27, 2023
* Revert "[PBCKP-259] fix for 'ERROR: Cannot create directory for older backup'… (postgrespro#526)" This reverts commit 1bb0762. * Revert "Add warning about using --start-time option" This reverts commit 8ce27c9. * Revert "Add tests for --start-time option on the one and few nodes" This reverts commit 1b75b4e. * Revert "Add --start-time option for backup" This reverts commit 3c74ebf. * Revert "Add backup start time as parameter for do_backup" This reverts commit 5f2283c. * Remove --start-time option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, rewrite --start_time implementation
Rewritten 5f2283c
Fixed:
Not yet fixed: