Skip to content

Check collector has started in pg_wait_sampling_reset_profile. #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions pg_wait_sampling.c
Original file line number Diff line number Diff line change
Expand Up @@ -808,8 +808,26 @@ pg_wait_sampling_reset_profile(PG_FUNCTION_ARGS)
{
LOCKTAG collectorTag;

/*
* This also guards against the case when the
* extension was not loaded at all, but this
* function was called. pgws_collector_hdr is
* NULL in this case.
*/
check_shmem();

/* The collector may have not started yet (it'd be a
* race condition with background worker startup to
* use latch without a check here).
* Or worse, registration of the worker might have been
* denied, if there are too many workers already.
* This is why we cannot wait for its start with a while
* loop.
*/
if (!pgws_collector_hdr->latch)
ereport(ERROR, (errcode(ERRCODE_INTERNAL_ERROR),
errmsg("pg_wait_sampling collector wasn't started")));

pgws_init_lock_tag(&queueTag, PGWS_QUEUE_LOCK);

LockAcquire(&queueTag, ExclusiveLock, false, false);
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy