Fix locale-dependent test case.

tglsfdc · tglsfdc · commit cd82e5c79d14 · 2023-04-07T10:35:11.000-04:00
psql parses the interval argument of \watch with locale-dependent strtod(). In commit 00beecf I added a test case that exercises a fractional interval, but I hard-coded 0.01 which doesn't work in locales where the radix point isn't ".". We don't want to change this longstanding parsing behavior, so fix the test case to generate a suitably locale-aware spelling. Report and patch by Alexander Korotkov. Discussion: https://postgr.es/m/CAPpHfdv+10Uk6FWjsh3+ju7kHYr76LaRXbYayXmrM7FBU-=Hgg@mail.gmail.com
diff --git a/src/bin/psql/t/001_basic.pl b/src/bin/psql/t/001_basic.pl
@@ -3,6 +3,7 @@
 
 use strict;
 use warnings;
+use locale;
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
@@ -351,9 +352,10 @@ sub psql_fails_like
 );
 
 # Check \watch
+# Note: the interval value is parsed with locale-aware strtod()
 psql_like(
 	$node,
-	'SELECT 1 \watch c=3 i=0.01',
+	sprintf('SELECT 1 \watch c=3 i=%g', 0.01),
 	qr/1\n1\n1/,
 	'\watch with 3 iterations');
 
