Skip to content

NodeApp.make_empty must pass os_ops and port_manager to nodes #265

New issue
New issue
Open
Open
NodeApp.make_empty must pass os_ops and port_manager to nodes#265
Labels
bugenhancement
@dmitry-lipetsk

Description

@dmitry-lipetsk
dmitry-lipetsk
opened on Jun 21, 2025

Constructor of NodeApp obtains os_ops but does not pass it to a new node. See this code:

testgres/testgres/node.py

Lines 2335 to 2346 in 44d61c2

self.os_ops = os_ops
def make_empty(
self,
base_dir=None,
port=None,
bin_dir=None):
real_base_dir = os.path.join(self.test_path, base_dir)
self.os_ops.rmdirs(real_base_dir, ignore_errors=True)
self.os_ops.makedirs(real_base_dir)
node = PostgresNode(base_dir=real_base_dir, port=port, bin_dir=bin_dir)

Also, the constructor of NodeApp can get port_manager object and pass it to the new nodes in make_empty, too.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugenhancement

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions
      pFad - Phonifier reborn

      Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

      Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


      Alternative Proxies:

      Alternative Proxy

      pFad Proxy

      pFad v3 Proxy

      pFad v4 Proxy