Skip to content

Make configuration parsing match docs ( If that is the way we want to go ) #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make configuration parsing match docs ( If that is the way we want to go ) #2986

wants to merge 1 commit into from

Conversation

DanielJoyce
Copy link

  • Added long to #[arg()] on config in cargo_embed CliOptions so it matches docs
  • Currently config profile is passed in as argument, whereas docs say it should be passed in via --config PROFILE_NAME flag

Fixes #2985

@DanielJoyce
Make configuration parsing match docs
35e2275 
* Added long to #[arg()] on config in cargo_embed CliOptions
  so it matches docs
* Currently config profile is passed in as argument, whereas
  docs say it should be passed in via --config PROFILE_NAME flag
Yatekii
Yatekii approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@Yatekii Yatekii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should rather fix the docs. It should be an unnamed argument :)

@bugadani
Copy link
Contributor

@Yatekii I don't understand why you approve a PR and then say we should do the exact opposite 👻 Would you expand on your comment please?

@Yatekii
Copy link
Member

Yatekii commented Dec 28, 2024

I was probably intoxicated with Club Mate at 5 in the morning :P

I should not have approved.

cargo embed <config> always was the format. Not cargo-embed --config <config>. I would personally like to keep it the old way. Most likely I approved the change that changed it though, sooo ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yatekii Yatekii Yatekii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs out of date? Or clap derive macro for cargo-embed is wrong
3 participants
@DanielJoyce @bugadani @Yatekii
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy