Skip to content

test(bundle): Use different Date constructor to get a local date #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2021
Merged

test(bundle): Use different Date constructor to get a local date #576

merged 1 commit into from
Sep 17, 2021

Conversation

eemeli
Copy link
Member

@eemeli eemeli commented Sep 14, 2021

Fixes #572 by using a different form of new Date(). The constructor parses string input as a UTC date, while numeric input uses the local timezone.

@eemeli eemeli requested a review from gregtatum September 14, 2021 13:53
gregtatum
gregtatum approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eemeli eemeli merged commit 186da02 into projectfluent:master Sep 17, 2021
@eemeli eemeli deleted the fix-date-test branch September 17, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregtatum gregtatum gregtatum approved these changes

Assignees
No one assigned
Labels
fluent-bundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing FluentDateTime test due to time zone differences of machine running test
2 participants
@eemeli @gregtatum
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy