Skip to content

Fix typescript types in DOMLocalization #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

Fix typescript types in DOMLocalization #643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions fluent-dom/src/dom_localization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export default class DOMLocalization extends Localization {
* Additionally, if this `DOMLocalization` has an observer, start observing
* `newRoot` in order to translate mutations in it.
*
* @param {Element} newRoot - Root to observe.
* @param {Element | DocumentFragment} newRoot - Root to observe.
*/
connectRoot(newRoot) {
for (const root of this.roots) {
Expand Down Expand Up @@ -158,7 +158,7 @@ export default class DOMLocalization extends Localization {
* Returns `true` if the root was the last one managed by this
* `DOMLocalization`.
*
* @param {Element} root - Root to disconnect.
* @param {Element | DocumentFragment} root - Root to disconnect.
* @returns {boolean}
*/
disconnectRoot(root) {
Expand Down Expand Up @@ -269,7 +269,7 @@ export default class DOMLocalization extends Localization {
*
* Returns a `Promise` that gets resolved once the translation is complete.
*
* @param {DOMFragment} frag - Element or DocumentFragment to be translated
* @param {Element | DocumentFragment} frag - Element or DocumentFragment to be translated
* @returns {Promise}
*/
translateFragment(frag) {
Expand Down Expand Up @@ -321,7 +321,7 @@ export default class DOMLocalization extends Localization {
/**
* Collects all translatable child elements of the element.
*
* @param {Element} element
* @param {Element | DocumentFragment} element
* @returns {Array<Element>}
* @private
*/
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy