Skip to content

Check and fix chararray string dimension names #10395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 20, 2025
+105 −28
Merged

Check and fix chararray string dimension names #10395

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e01580a
MIN: forward variable name down to coders for CharacterArrayCoder
kmuehlbauer Jun 4, 2025
9f89f09
FIX: check character arrays for possible changes in dimension name an…
kmuehlbauer Jun 4, 2025
0fc9024
add whats-new.rst entry
kmuehlbauer Jun 4, 2025
7031880
fix subclass in test
kmuehlbauer Jun 4, 2025
a1a2856
Merge branch 'main' into fix-chararray-strings
kmuehlbauer Jun 5, 2025
fa176e1
only rewrite dimension name, if new length differs from original length
kmuehlbauer Jun 5, 2025
6d3a476
Merge branch 'main' into fix-chararray-strings
kmuehlbauer Jun 6, 2025
336de4a
Merge branch 'main' into fix-chararray-strings
kmuehlbauer Jun 12, 2025
350623a
Refactor out validation logic
kmuehlbauer Jun 12, 2025
9ca5e7e
Merge branch 'main' into fix-chararray-strings
kmuehlbauer Jun 12, 2025
9c0b043
Merge branch 'main' into fix-chararray-strings
kmuehlbauer Jun 13, 2025
c86f9a4
Merge branch 'main' into fix-chararray-strings
kmuehlbauer Jun 17, 2025
910f4b4
Merge branch 'main' into fix-chararray-strings
kmuehlbauer Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add whats-new.rst entry
  • Loading branch information
@kmuehlbauer
kmuehlbauer committed Jun 4, 2025
commit 0fc902425d0e96bbdb4e4cf641e74cb81a7cc64c
5 changes: 5 additions & 0 deletions doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ Bug fixes
(:pull:`10352`). By `Spencer Clark <https://github.com/spencerkclark>`_.
- Avoid unsafe casts from float to unsigned int in CFMaskCoder (:issue:`9815`, :pull:`9964`).
By ` Elliott Sales de Andrade <https://github.com/QuLogic>`_.
- Check and fix character array string dimension names, issue warnings as needed (:issue:`6352`, :pull:`10395`).
By `Kai Mühlbauer <https://github.com/kmuehlbauer>`_.

Performance
~~~~~~~~~~~
Expand All @@ -83,6 +85,9 @@ Documentation
Internal Changes
~~~~~~~~~~~~~~~~

- Forward variable name down to coders for AbstractWritableDataStore.encode_variable and subclasses. (:pull:`10395`).
By `Kai Mühlbauer <https://github.com/kmuehlbauer>`_.

.. _whats-new.2025.04.0:

v2025.04.0 (Apr 29, 2025)
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy