Skip to content

Unnecessary tuple/list literal #10450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

Conversation

DimitriPapadopoulos
Copy link
Contributor

Rewrite as set literal syntax.

  • Closes #xxxx
  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

Rewrite as set literal syntax.
@@ -1397,7 +1397,7 @@ def test_apply_dask_new_output_sizes_not_supplied_same_dim_names() -> None:
da,
input_core_dims=[["i", "j"]],
output_core_dims=[["i", "j"]],
exclude_dims=set(("i", "j")),
exclude_dims={"i", "j"},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the intent was {"i", "j"}, not {('i', 'j')}.

@max-sixty max-sixty merged commit e159879 into pydata:main Jun 27, 2025
33 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the PTC-W0018 branch June 28, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy